Update DaprActorsIT wait strategy #1306
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Cruz <[email protected]>
salaboy
reviewed
Apr 12, 2025
| @@ -53,7 +53,7 @@ public class DaprActorsIT { | |||
| private static final Random RANDOM = new Random(); | |||
| private static final int PORT = RANDOM.nextInt(1000) + 8000; | |||
|
|
|||
| private static final String ACTORS_MESSAGE_PATTERN = ".*Actor API level in the cluster has been updated to 10.*"; | |||
| private static final String ACTORS_MESSAGE_PATTERN = ".*Found Subscription.*"; | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1306 +/- ##
============================================
- Coverage 76.91% 75.47% -1.44%
- Complexity 1592 1616 +24
============================================
Files 145 193 +48
Lines 4843 5101 +258
Branches 562 555 -7
============================================
+ Hits 3725 3850 +125
- Misses 821 935 +114
- Partials 297 316 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1305
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: