Skip to content

feat: Support registering activities with custom name #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

javier-aliaga
Copy link
Contributor

@javier-aliaga javier-aliaga commented Jun 20, 2025

Description

This PR allow to register activities with a custom name. This is useful in case you want to reuse activities or want to give more meaningful name to the activity.

    builder.registerActivity(FirstActivity.class);
    builder.registerActivity("a",FirstActivity.class);
    builder.registerActivity("b",FirstActivity.class);

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@javier-aliaga javier-aliaga force-pushed the javi-use-name-to-register-activity branch 3 times, most recently from 8a48dec to 28f7d93 Compare June 20, 2025 15:41
@javier-aliaga javier-aliaga marked this pull request as ready for review June 20, 2025 15:42
@javier-aliaga javier-aliaga requested review from a team as code owners June 20, 2025 15:42
@javier-aliaga javier-aliaga force-pushed the javi-use-name-to-register-activity branch from 28f7d93 to 76d1666 Compare June 20, 2025 15:54
@javier-aliaga javier-aliaga changed the title feat: Support register of activities with custom name feat: Support registering activities with custom name Jun 20, 2025
@javier-aliaga javier-aliaga force-pushed the javi-use-name-to-register-activity branch from 76d1666 to 2028f95 Compare June 20, 2025 16:16
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (d759c53) to head (2028f95).
Report is 172 commits behind head on master.

Files with missing lines Patch % Lines
...orkflows/runtime/WorkflowActivityClassWrapper.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1431      +/-   ##
============================================
+ Coverage     76.91%   78.48%   +1.56%     
- Complexity     1592     1871     +279     
============================================
  Files           145      230      +85     
  Lines          4843     5795     +952     
  Branches        562      601      +39     
============================================
+ Hits           3725     4548     +823     
- Misses          821      927     +106     
- Partials        297      320      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@salaboy
Copy link
Collaborator

salaboy commented Jun 21, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants