-
Notifications
You must be signed in to change notification settings - Fork 219
feat: Support registering activities with custom name #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
javier-aliaga
wants to merge
1
commit into
dapr:master
Choose a base branch
from
javier-aliaga:javi-use-name-to-register-activity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Support registering activities with custom name #1431
javier-aliaga
wants to merge
1
commit into
dapr:master
from
javier-aliaga:javi-use-name-to-register-activity
+132
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a48dec
to
28f7d93
Compare
28f7d93
to
76d1666
Compare
Signed-off-by: Javier Aliaga <[email protected]>
76d1666
to
2028f95
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1431 +/- ##
============================================
+ Coverage 76.91% 78.48% +1.56%
- Complexity 1592 1871 +279
============================================
Files 145 230 +85
Lines 4843 5795 +952
Branches 562 601 +39
============================================
+ Hits 3725 4548 +823
- Misses 821 927 +106
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allow to register activities with a custom name. This is useful in case you want to reuse activities or want to give more meaningful name to the activity.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: