-
Notifications
You must be signed in to change notification settings - Fork 223
Use xolstice protobuf Maven plugin #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dapr/approvers-java-sdk could you please take a look. This should be an easy review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@artur-ciocanu ok.. can you share a bit more how did you tested this? I do like this change.. but the problem that I see is having time to test this.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Artur Ciocanu <[email protected]>
315ed70
c21993e
to
315ed70
Compare
@salaboy great question, the validation process went like this:
Let me know if the validation I have performed are enough or you think we should do some additional checks. |
@salaboy @siri-varma and @javier-aliaga I had to resolve some conflicts, could you please approve one more time. Thank you! |
@artur-ciocanu reapproved! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1536 +/- ##
============================================
+ Coverage 76.91% 78.88% +1.96%
- Complexity 1592 1935 +343
============================================
Files 145 237 +92
Lines 4843 5952 +1109
Branches 562 611 +49
============================================
+ Hits 3725 4695 +970
- Misses 821 938 +117
- Partials 297 319 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PRs improves the Protobug codegen by using org.xolstice Maven plugin. It properly detects OS and uses the right protoc binary that doesn't conflict with host binary.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1535
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: