Skip to content

Conversation

@BuckyMaler
Copy link
Contributor

This deletes the root.css and tailwind.css auto generated files and adds them to the .gitignore. Since these files are auto generated and not meant to be edited directly, there's no reason to track them with git.

@vercel
Copy link

vercel bot commented Jun 14, 2025

@BuckyMaler is attempting to deploy a commit to the darkroom Team on Vercel.

A member of the Team first needs to authorize it.

@clementroche clementroche requested review from Copilot and feledori June 15, 2025 17:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes auto-generated CSS files from version control and ensures they aren’t tracked by Git.

  • Deletes styles/css/root.css
  • Adds generated CSS files (root.css, tailwind.css) to .gitignore
Comments suppressed due to low confidence (1)

styles/css/root.css:1

  • The PR description mentions deleting tailwind.css as well, but only root.css is removed in this diff. Please include the deletion of tailwind.css or update the description to match the actual changes.
-/*

@feledori
Copy link
Contributor

thanks for the pr first off! I think for now I would leave it in as it makes controlling changes to the generator functions easier. You would commit these files if they weren't generated, as they are the source of truth for consumption in the website. Keeping these makes debugging easier as you can easily change stuff in the generated files to fix stuff and then port it back to the generator.

@BuckyMaler
Copy link
Contributor Author

Thanks for taking a look!

Keeping these makes debugging easier as you can easily change stuff in the generated files to fix stuff and then port it back to the generator.

That workflow would work the same locally with these changes. The files can still be viewed and edited in your editor.

By not ignoring these files you could end up with sync issues. E.g. when I first cloned and ran (bun dev) changes were made to tailwind.css because it was out of sync with the generator. That has since been fixed.

@BuckyMaler
Copy link
Contributor Author

Maybe add a check in the pre-commit hook instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants