Skip to content

Some fixes related to unified OpenCL memory - #21354

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:unified_clmem
Jul 22, 2026
Merged

TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:unified_clmem

Conversation

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator
  1. The remaining total system memory was wrongfully decreased too far when using unified cl memory possibly leading to decreased performance, also wrong log reports later on.
  2. The available memory restrictions due to OpenCL and the resource level are calculated now inside dt_opencl_update_setting(), this is called at startup and when changing preferences so cl_mem setting are always up-to-date and logged there.
  3. Checks for available cl_mem when allocating buffers/images have been fixed, relevant for small devices with unified memory.
  4. Simplified pipe starting logs, we don't do checks there any more as we do that in (2)

@jenshannoschwalm jenshannoschwalm added this to the 5.8 milestone Jun 19, 2026
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug OpenCL Related to darktable OpenCL code labels Jun 19, 2026
@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author

@TurboGit Integration testsuite ok

@jenshannoschwalm
jenshannoschwalm force-pushed the unified_clmem branch 2 times, most recently from 6f05453 to 4987f18 Compare June 30, 2026 19:30
@jenshannoschwalm
jenshannoschwalm force-pushed the unified_clmem branch 2 times, most recently from da59181 to b35f131 Compare July 17, 2026 05:05
1. The remaining total system memory was wrongfully decreased too far when using unified cl memory
   possibly leading to decreased performance, also wrong log reports later on.
2. The available memory restrictions due to OpenCL and the resource level are calculated now inside
   dt_opencl_update_setting(), this is called at startup and when changing preferences so cl_mem
   setting are always up-to-date and logged there.
3. Checks for available cl_mem when allocating buffers/images have been fixed, relevant for small
   devices with unified memory.
4. Simplified pipe starting logs, we don't do checks there any more as we do that in (2)

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit 664e1ff into darktable-org:master Jul 22, 2026
5 checks passed
@jenshannoschwalm
jenshannoschwalm deleted the unified_clmem branch July 22, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug OpenCL Related to darktable OpenCL code release notes: pending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants