Skip to content

Fix gphoto conf compares #21456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TurboGit merged 1 commit into from
Jun 30, 2026
Merged

Fix gphoto conf compares #21456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/common/camera_control.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2251,13 +2251,14 @@ static void _camera_configuration_notify_change(const dt_camctl_t *c,
// https://redmine.darktable.org/issues/12004 for the crash
// resulting from that.

// Get new_config and old_config value to be compared
// Get new_config and old_config value to be compared independent from locale
if(new_config_type == GP_WIDGET_RANGE)
{
float value;
if(gp_widget_get_value(new_config, &value) != GP_OK)
goto end;
new_config_value = g_strdup_printf("%.0f", value);
new_config_value = (char *)g_malloc(G_ASCII_DTOSTR_BUF_SIZE);
g_ascii_dtostr(new_config_value, G_ASCII_DTOSTR_BUF_SIZE, value);
}
else
if(gp_widget_get_value(new_config, &new_config_value) != GP_OK)
Expand All @@ -2268,7 +2269,8 @@ static void _camera_configuration_notify_change(const dt_camctl_t *c,
float value;
if(gp_widget_get_value(old_config_child, &value) != GP_OK)
goto end;
old_config_value = g_strdup_printf("%.0f", value);
old_config_value = (char *)g_malloc(G_ASCII_DTOSTR_BUF_SIZE);
g_ascii_dtostr(old_config_value, G_ASCII_DTOSTR_BUF_SIZE, value);
}
else
if(gp_widget_get_value(old_config_child, &old_config_value) != GP_OK)
Expand Down
Loading