Skip to content

Warning about active blue mapping in colorin - #21487

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:no_blue_mapping_colorin
Jul 22, 2026
Merged

TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:no_blue_mapping_colorin

Conversation

@jenshannoschwalm

@jenshannoschwalm jenshannoschwalm commented Jul 4, 2026 •

Copy link
Copy Markdown
Collaborator

Blue mapping warning

If blue_mapping was still switched on from very old edits we at least want a warning.

If blue_mapping was still switched on from very old edits we at least want a warning.
@jenshannoschwalm jenshannoschwalm added this to the 5.8 milestone Jul 4, 2026
@jenshannoschwalm jenshannoschwalm added priority: low core features work as expected, only secondary/optional features don't scope: image processing correcting pixels scope: codebase making darktable source code easier to manage labels Jul 4, 2026
@ralfbrown

Copy link
Copy Markdown
Collaborator

The test suite wasn't started until ~2021, by which time it wasn't possible to create sidecars for the suite with that option enabled.

When I worked on colorin a few years ago, I didn't find any sidecars with blue mapping enabled, so I stepped very carefully around that code.

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author

Yes i saw that :-) thus i had to do a test version allowing toggling it on/off.
I had hoped that maybe some copy of history might have crept in the suite. None found.

I also did a test version enforcing it to be on running the suite, no visibly diffs to me.

after that i did the pr :-)

@jenshannoschwalm
jenshannoschwalm marked this pull request as draft July 5, 2026 05:38
@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author

Sorry - i checked again the results of the full suite and there are indeed substancial differences in various tests if i force blue_mapping on (for sure it is not good with the now default late_shot-D65 mode.). So i guess removing it from code might give strange results for some images and we can't really test those.

Unfortunately there is something more bad with this test (blue_mapping on for cl and cpu code) It should at least produce identical results - it doesn't and give large differences. I did a quick check on OpenCL code and couldn't spot anything obvious so far ...

@jenshannoschwalm
jenshannoschwalm force-pushed the no_blue_mapping_colorin branch from cd74f13 to 5ebef68 Compare July 5, 2026 17:43
@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author

I removed the second commit and just left the code that gives at least a warning about those old edits.

@jenshannoschwalm
jenshannoschwalm marked this pull request as ready for review July 5, 2026 17:44
@jenshannoschwalm jenshannoschwalm changed the title No blue mapping in colorin module Warning about active blue mapping in colorin Jul 5, 2026

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit 0fa4ac6 into darktable-org:master Jul 22, 2026
5 checks passed
@jenshannoschwalm
jenshannoschwalm deleted the no_blue_mapping_colorin branch July 22, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low core features work as expected, only secondary/optional features don't scope: codebase making darktable source code easier to manage scope: image processing correcting pixels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants