Repository navigation
Fix OOB read in lut3d cube, 3dl and compressed LUT paths - #21494
Merged
Merged
Conversation
Arecsu
force-pushed
the
master
branch
2 times, most recently
from
July 6, 2026 00:41
9c15cfb to
74b2bce
Compare
The interpolation functions use for_each_channel() which reads DT_PIXEL_SIMD_CHANNELS (4) floats per LUT grid point, but each entry has only 3 components. The last grid point access overruns the buffer by 1 float. This was already fixed for the HALD PNG path in commit e14e55d. Apply the same over-allocation (+1 float, zeroed) to the .cube, .3dl and compressed GMIC LUT loading paths.
Member
|
Needs a release note entry, TIA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interpolation functions use
for_each_channel()which readsDT_PIXEL_SIMD_CHANNELS(4) floats per LUT grid point, but each entry has only 3 components. When processing the last grid point (level³ - 1), the SIMD read overruns the buffer by 1 float.This was already fixed for the HALD PNG path in commit e14e55d. This patch extends the same over-allocation (+1 float, zeroed) to the
.cube,.3dland compressed GMIC LUT loading paths.Fixes #21493