Conversation
The library.db corruption dialog was copied from the data.db one and still printed dbfilename_data, so a broken library.db was reported as data.db while the terminal message named library.db. The dialog's "delete database" button unlinks library.db, so a user trusting the dialog could delete the library believing they were removing data.db.
da-phil
force-pushed
the
pl/fix_wrong_db_name_reference_in_gui
branch
from
October 3, 2026 11:54
cdac6e2 to
abbefbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The library.db corruption dialog was copied from the data.db one and still printed dbfilename_data, so a broken library.db was reported as "data.db" while the terminal message named it "library.db".
The dialog's "delete database" button unlinks library.db, so a user trusting the dialog could delete the library believing they were removing data.db.
Checklist
src/tests/integration/where the pixelpipe is touched, ordarktable-clias a headless smoke test._(), new preferences are registered indata/darktableconfig.xml.in.RELEASE_NOTES.mdentry was added (only needed if fixing an issue in a release). Do not reference GitHub issues.