Skip to content

Handling Case-Sensitive Column Names in Views #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handling Case-Sensitive Column Names in Views #1904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions lib/Ora2Pg.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3807,7 +3807,8 @@ sub read_view_from_file
$self->{views}{$v_name}{text} = $v_def;
$self->{views}{$v_name}{iter} = $tid;
# Remove constraint
while ($v_alias =~ s/(,[^,\(]+\(.*)$//) {};
# while ($v_alias =~ s/(,[^,\(]+\(.*)$//) {};
while ($v_alias =~ s/(,[^,"\(]+\(.*\))$//) {};
my @aliases = split(/\s*,\s*/, $v_alias);
foreach (@aliases)
{
Expand Down Expand Up @@ -5126,6 +5127,22 @@ sub export_view
$sql_output .= "CREATE$self->{create_or_replace} VIEW $tmpv (";
my $count = 0;
my %col_to_replace = ();
# need to write the condition if views alias as mentioned within ""
if (exists $self->{views}{$view}{alias}) {
my $alias_ref = $self->{views}{$view}{alias};

if (ref($alias_ref) eq 'ARRAY') {
my @flattened_alias;

foreach my $sub_array (@$alias_ref) {
if (ref($sub_array) eq 'ARRAY') {
push @flattened_alias, join(" ", @$sub_array);
}
}
$self->{views}{$view}{alias} = [ map { [$_] } @flattened_alias ];

}
}
foreach my $d (@{$self->{views}{$view}{alias}})
{
if ($count == 0) {
Expand All @@ -5152,7 +5169,16 @@ sub export_view
$cost_value += $cost;
$sql_output .= "\n-- Estimed cost of view [ $view ]: " . sprintf("%2.2f", $cost);
}
$sql_output .= "\n";
# $sql_output .= "\n";
# writing if condition that the fname is like "abc.def" --> handling these kind of strings
if ($fname =~ /"[^"]*?(?:\.\s|\.|)[^"]*?"/)
{
$sql_output .= $fname;
}
else
{
$sql_output .= $self->quote_object_name($fname);
}
}

if ($self->{force_owner})
Expand Down