Skip to content

refactor: standardize project-wide analysis options #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2025
Merged

refactor: standardize project-wide analysis options #1842

merged 4 commits into from
Aug 21, 2025

Conversation

felangel
Copy link
Contributor

Status

READY

Description

  • refactor: standardize project-wide analysis options
    • everything (with the exception of examples) uses dart_frog_lint now and references the root analysis_options.yaml

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Aug 21, 2025
@felangel felangel added the refactor A code change that neither fixes a bug nor add a feature label Aug 21, 2025
felangel
felangel commented Aug 21, 2025
View reviewed changes
bricks/dart_frog_prod_server/hooks/lib/src/exit_overrides.dart
@@ -3,6 +3,8 @@ import 'dart:io' as io;

const _asyncRunZoned = runZoned;

void defaultExit(int code) => ExitOverrides.current?.exit ?? io.exit;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry picked this to fix coverage from #1825

@felangel felangel merged commit 45b93e6 into main Aug 21, 2025
49 checks passed
@felangel felangel deleted the refactor/standardize-analysis-options branch August 21, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

@alestiago alestiago Awaiting requested review from alestiago alestiago is a code owner

@marcossevilla marcossevilla Awaiting requested review from marcossevilla marcossevilla is a code owner

@renancaraujo renancaraujo Awaiting requested review from renancaraujo renancaraujo is a code owner

@wolfenrain wolfenrain Awaiting requested review from wolfenrain wolfenrain is a code owner

Assignees

@felangel felangel

Labels
refactor A code change that neither fixes a bug nor add a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felangel @erickzanardo