-
Notifications
You must be signed in to change notification settings - Fork 28
#3329. Add tests for "corresponding public name" #3361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments added.
LanguageFeatures/Private-named-parameters/static_semantics_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A02_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A02_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A02_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A02_t02.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Updated. PTAL.
LanguageFeatures/Private-named-parameters/static_semantics_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A02_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A02_t02.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a couple of comments.
LanguageFeatures/Private-named-parameters/static_semantics_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A02_t01.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Updated. PTAL.
LanguageFeatures/Private-named-parameters/static_semantics_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Private-named-parameters/static_semantics_A02_t01.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2025-10-31 [email protected] Fixes dart-lang/co19#3378. Add an error for the analyzer in definition_t16.dart (dart-lang/co19#3379) 2025-10-30 [email protected] dart-lang/co19#3329. Add more private named parameters tests (dart-lang/co19#3375) 2025-10-30 [email protected] Update ffi package version (dart-lang/co19#3376) 2025-10-29 [email protected] dart-lang/co19#3329. Add tests for "corresponding public name" (dart-lang/co19#3361) 2025-10-29 [email protected] Fixes dart-lang/co19#3373. Fix constructor invocation in definition_t16.dart (dart-lang/co19#3374) 2025-10-29 [email protected] dart-lang/co19#3329. Add private named parameters tests. (dart-lang/co19#3362) 2025-10-29 [email protected] dart-lang/co19#2825. Add sanity rules tests (dart-lang/co19#3370) 2025-10-29 [email protected] Fixes dart-lang/co19#3371. Remove obsolete test Language/Classes/definition_t14.dart (dart-lang/co19#3372) [email protected], [email protected] Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: I7326b0aacf83a64a5f89dc6a22da836af6961a93 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459260 Reviewed-by: Erik Ernst <[email protected]> Auto-Submit: Sergey Grekhov <[email protected]> Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
No description provided.