-
Notifications
You must be signed in to change notification settings - Fork 69
[native_toolchain_c] Add linking for iOS #2363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
Skipping the breaking-check because of #2361. Local run is clean:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @goderbauer 🙏
@@ -16,7 +16,7 @@ void main() { | |||
flutterAndroidNdkVersionLowestSupported, | |||
flutterAndroidNdkVersionHighestSupported, | |||
]) { | |||
group('Android API$apiLevel', () { | |||
group('Android API$apiLevel:', () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, to make it match the other tests.
targetArchitecture: targetArchitecture, | ||
linkModePreference: LinkModePreference.dynamic, | ||
cCompiler: cCompiler, | ||
android: androidTargetNdkApi != null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be targetOs == OS.android
instead, with a !
on androidTargetNdkApi
? Ditto for the other OSes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we check at the top of the method that androidTargetNdkApi must be set iff targetOS is Android it shouldn't matter logically. I find the current way without the extra null check easier to read, which is why I opted for that one.
Towards #1376
We were basically able re reuse all the macOS work from #2360 for iOS and just had to add iOS-specific Tests.
This PR also fixes an issue with the treeshaking tests, which were accidentally overwriting size results from other test cases. An
expect
has been added to guard against this issue in the future.Hint for reviewers:
treeshake_helper.dart
is easier to review with github'sHide whitespace
option turned on.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.