Skip to content

Update dependencies across 3 packages #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2025
Merged

Update dependencies across 3 packages #479

merged 4 commits into from
Aug 5, 2025

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Aug 4, 2025

No description provided.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 4, 2025
@kevmoo kevmoo requested review from devoncarew and jonasfj August 4, 2025 21:02
@kevmoo kevmoo enabled auto-merge (squash) August 4, 2025 21:06
lrhn
lrhn reviewed Aug 5, 2025
View reviewed changes
pkgs/shelf_router_generator/test/server_test.dart
required String path,
required String result,
}) =>
void testGet({required String path, required String result}) =>
test('GET $path', () async {
final result = await http.get(server.uri.resolve(path));
expect(result, equals(result));
Copy link
Member

@lrhn lrhn Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks tautological. Maybe rename one of the result variables?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a reformat pass. We should come back later w/ other code changes.

lrhn
lrhn reviewed Aug 5, 2025
View reviewed changes
pkgs/shelf_router_generator/lib/src/shelf_router_generator.dart
),
)
.expand((i) => i)
.toList();
Copy link
Member

@lrhn lrhn Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be literal:

    classes[cls] =
      [for (e in elements)
         for (var a in _routeType.annotationsOfExact(e))
           _Handler(
             a.getField('verb')!.toStringValue()!,
             a.getField('route')!.toStringValue()!,
             e)
      ];

I think it's easier to read.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but also this is just a reformat pass. We should come back later w/ other code changes.

devoncarew
devoncarew approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two inline edits; lgtm

pkgs/shelf_test_handler/CHANGELOG.md
* Require Dart `^3.3.0`.
* Require `shelf: ^1.1.0`
* Require `test: ^1.25.15`
* Require `sdk: ^3.5.0`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For similarity with other entries:

Suggested change
* Require `sdk: ^3.5.0`.
* Require Dart `3.5`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL! I was trying to explicitly make these more copy-paste so they are always consistent and minimal effort.

Uh...

I guess auto-merge decided for us.

pkgs/shelf_router_generator/CHANGELOG.md
* Require `build: ^3.0.0`
* Require `build_config: ^1.1.0`
* Require `source_gen: ^3.0.0`
* Require `sdk: ^3.7.0`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Require `sdk: ^3.7.0`
* Require Dart `3.7`.

@kevmoo kevmoo merged commit 2a46b4f into master Aug 5, 2025
27 checks passed
@kevmoo kevmoo deleted the update_deps branch August 5, 2025 18:54
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 7, 2025
@devoncarew
[deps] rev dartdoc, ecosystem, i18n, shelf, test, tools, web, webdev
00240e8 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/414953e..82b48b5):
  82b48b53  2025-08-05  István Soós  Update highlight.js download instructions and resources. (dart-lang/dartdoc#4081)

ecosystem (https://github.com/dart-lang/ecosystem/compare/2fe3618..4543c38):
  4543c38  2025-08-06  Devon Carew  address a `Bad state: No element` element exception (dart-lang/ecosystem#321)
  e14472f  2025-08-06  Devon Carew  add a roadmap to our various mono-repos (dart-lang/ecosystem#318)
  e83479a  2025-08-06  Moritz  Fixes to health (dart-lang/ecosystem#363)
  552f534  2025-08-06  Moritz  Update API tool hash (dart-lang/ecosystem#362)

i18n (https://github.com/dart-lang/i18n/compare/c45e050..25cdb1b):
  25cdb1b4  2025-08-07  Moritz  Reenable mac size checks (dart-lang/i18n#1001)

shelf (https://github.com/dart-lang/shelf/compare/082d3ac..2a46b4f):
  2a46b4f  2025-08-05  Kevin Moore  Update dependencies across 3 packages (dart-lang/shelf#479)

test (https://github.com/dart-lang/test/compare/5aef971..9354f23):
  9354f239  2025-08-07  Liam Appelbe  Add `--coverage-path` and `--branch-coverage` options (dart-lang/test#2517)

tools (https://github.com/dart-lang/tools/compare/5e977d6..1b52e89):
  1b52e89e  2025-08-06  Moritz  Configure Gemini code review (dart-lang/tools#2141)

web (https://github.com/dart-lang/web/compare/1d5771b..f3c960f):
  f3c960f  2025-08-06  Nikechukwu  [web_generator] Add support for passing files as globs (dart-lang/web#427)
  f51cc85  2025-08-06  Nikechukwu  [interop] Add Support for Namespaces (dart-lang/web#436)

webdev (https://github.com/dart-lang/webdev/compare/7ff2d07..94c172c):
  94c172cc  2025-08-05  Nicholas Shahan  Wait for any remaining output in e2e_test.dart (dart-lang/webdev#2663)

Change-Id: Ie18635903f7379bc27e7ae23b916e10e4bdcef94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444360
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 7, 2025
@devoncarew
Revert "[deps] rev dartdoc, ecosystem, i18n, shelf, test, tools, web,…
e9c56bf 
… webdev"

This reverts commit 00240e8.

Reason for revert: failures on HHH

Original change's description:
> [deps] rev dartdoc, ecosystem, i18n, shelf, test, tools, web, webdev
>
> Revisions updated by `dart tools/rev_sdk_deps.dart`.
>
> dartdoc (https://github.com/dart-lang/dartdoc/compare/414953e..82b48b5):
>   82b48b53  2025-08-05  István Soós  Update highlight.js download instructions and resources. (dart-lang/dartdoc#4081)
>
> ecosystem (https://github.com/dart-lang/ecosystem/compare/2fe3618..4543c38):
>   4543c38  2025-08-06  Devon Carew  address a `Bad state: No element` element exception (dart-lang/ecosystem#321)
>   e14472f  2025-08-06  Devon Carew  add a roadmap to our various mono-repos (dart-lang/ecosystem#318)
>   e83479a  2025-08-06  Moritz  Fixes to health (dart-lang/ecosystem#363)
>   552f534  2025-08-06  Moritz  Update API tool hash (dart-lang/ecosystem#362)
>
> i18n (https://github.com/dart-lang/i18n/compare/c45e050..25cdb1b):
>   25cdb1b4  2025-08-07  Moritz  Reenable mac size checks (dart-lang/i18n#1001)
>
> shelf (https://github.com/dart-lang/shelf/compare/082d3ac..2a46b4f):
>   2a46b4f  2025-08-05  Kevin Moore  Update dependencies across 3 packages (dart-lang/shelf#479)
>
> test (https://github.com/dart-lang/test/compare/5aef971..9354f23):
>   9354f239  2025-08-07  Liam Appelbe  Add `--coverage-path` and `--branch-coverage` options (dart-lang/test#2517)
>
> tools (https://github.com/dart-lang/tools/compare/5e977d6..1b52e89):
>   1b52e89e  2025-08-06  Moritz  Configure Gemini code review (dart-lang/tools#2141)
>
> web (https://github.com/dart-lang/web/compare/1d5771b..f3c960f):
>   f3c960f  2025-08-06  Nikechukwu  [web_generator] Add support for passing files as globs (dart-lang/web#427)
>   f51cc85  2025-08-06  Nikechukwu  [interop] Add Support for Namespaces (dart-lang/web#436)
>
> webdev (https://github.com/dart-lang/webdev/compare/7ff2d07..94c172c):
>   94c172cc  2025-08-05  Nicholas Shahan  Wait for any remaining output in e2e_test.dart (dart-lang/webdev#2663)
>
> Change-Id: Ie18635903f7379bc27e7ae23b916e10e4bdcef94
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444360
> Auto-Submit: Devon Carew <[email protected]>
> Commit-Queue: Konstantin Shcheglov <[email protected]>
> Reviewed-by: Konstantin Shcheglov <[email protected]>

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I239eff7add9e5432c67b05c8f7731e1a79d4e4db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444387
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Alexander Aprelev <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 8, 2025
@devoncarew
[deps] rev dartdoc, ecosystem, i18n, shelf, tools, web, webdev
1e3a0fd 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/414953e..82b48b5):
  82b48b53  2025-08-05  István Soós  Update highlight.js download instructions and resources. (dart-lang/dartdoc#4081)

ecosystem (https://github.com/dart-lang/ecosystem/compare/2fe3618..4543c38):
  4543c38  2025-08-06  Devon Carew  address a `Bad state: No element` element exception (dart-lang/ecosystem#321)
  e14472f  2025-08-06  Devon Carew  add a roadmap to our various mono-repos (dart-lang/ecosystem#318)
  e83479a  2025-08-06  Moritz  Fixes to health (dart-lang/ecosystem#363)
  552f534  2025-08-06  Moritz  Update API tool hash (dart-lang/ecosystem#362)

i18n (https://github.com/dart-lang/i18n/compare/c45e050..25cdb1b):
  25cdb1b4  2025-08-07  Moritz  Reenable mac size checks (dart-lang/i18n#1001)

shelf (https://github.com/dart-lang/shelf/compare/082d3ac..2a46b4f):
  2a46b4f  2025-08-05  Kevin Moore  Update dependencies across 3 packages (dart-lang/shelf#479)

tools (https://github.com/dart-lang/tools/compare/5e977d6..1b52e89):
  1b52e89e  2025-08-06  Moritz  Configure Gemini code review (dart-lang/tools#2141)

web (https://github.com/dart-lang/web/compare/1d5771b..f3c960f):
  f3c960f  2025-08-06  Nikechukwu  [web_generator] Add support for passing files as globs (dart-lang/web#427)
  f51cc85  2025-08-06  Nikechukwu  [interop] Add Support for Namespaces (dart-lang/web#436)

webdev (https://github.com/dart-lang/webdev/compare/7ff2d07..94c172c):
  94c172cc  2025-08-05  Nicholas Shahan  Wait for any remaining output in e2e_test.dart (dart-lang/webdev#2663)

Change-Id: Id553d989bdb5aea483e6ad7d955a965cfaa3cf16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444362
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrhn lrhn lrhn left review comments

@devoncarew devoncarew devoncarew approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
package:shelf_router_generator package:shelf_test_handler package:shelf_web_socket type-infra A repository infrastructure change or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevmoo @devoncarew @lrhn