-
Notifications
You must be signed in to change notification settings - Fork 220
Expand Analyzer constraints to allow 8.x #2518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Prepare to publish with no other package changes.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
Will need to coordinate when the min analyzer dep can be bumped.
@@ -348,6 +350,8 @@ class _Parser { | |||
|
|||
String? _findConstructorNameFromInstantiation( | |||
InstanceCreationExpression constructor, String className) { | |||
// Replace name2 with name when bumping min analyzer dependency | |||
// ignore: deprecated_member_use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not doing it now?
When we will start removing old APIs from the analyzer, this will cause issues.
And than we will have to do one more iteration to clean this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we can fix this now. Do you know the correct min version to include the new name
field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.0.0
- Deprecate
NamedType.name2
, usename
instead.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Prepare to publish with no other package changes.