[interop] Add support for importing and exporting declarations, as well as multi-file output #418
+2,046
−256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # web_generator/lib/src/interop_gen/transform/transformer.dart # web_generator/lib/src/js/typescript.types.dart
- added import support - added gen of code inside file in the case of non multi-import - added support for multiple file generation - using `TransformManager` for managing transformation of code
nikeokoronkwo
changed the title
# Conflicts: # web_generator/lib/src/ast/declarations.dart # web_generator/lib/src/interop_gen/transform.dart # web_generator/lib/src/interop_gen/transform/transformer.dart # web_generator/lib/src/js/typescript.types.dart
srujzs
reviewed
Jul 22, 2025
web_generator/test/integration/interop_gen/project/input/a.d.ts
Outdated
Show resolved
Hide resolved
web_generator/test/integration/interop_gen/import_export_input.d.ts
Outdated
Show resolved
Hide resolved
srujzs
approved these changes
Jul 30, 2025
| // export reference | ||
| if (decl.isEmpty) _getTypeFromDeclaration(actualName, []); | ||
|
|
||
| exportSet.removeWhere((e) => e.name == actualName.text); |
There was a problem hiding this comment.
I'm guessing this is needed because the new export shadows the old export.
A question: Can export specifiers and export declarations interleave? Can there be multiple of each? Do we follow the ordering correctly if so?
There was a problem hiding this comment.
Export specifiers are contained in export declarations. There can be multiple export declarations. The order shouldn't matter, as you cannot export a symbol twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #378
Fixes #387
This PR is for adding support for multiple file processing, with support for exporting and importing declarations even between files.
It makes use of a
TransformManagerwhich transforms various files and uses aProgramMapto memoize and keep track of dependencies across files, which helps in reducing expensive transform calls to declarations already referenced from other files.Rather than transforming every declaration in a source file, the type checker gets the declarations exported from the file, and processes those declarations and its dependencies only, making processing faster
The type checker helps to resolve types and imports, as well as resolve import declarations. Import declarations are not parsed by default so that we know we are only making use of imports actually referenced in code (which is helpful in single outputs for instance).
(The program map makes use of
package:pathsPathMapto easily work with paths for files and declarations, as the TS output may resolve either to a relative import in the file, or may reference the declaration externally as an absolute path).Imported declarations are declared as
ReferredTypes with aurlproperty, which allows for referencing the normalExports are rewritten based on how they are specified, and are processed after transformation (since they are separate declarations and may be referenced as they are.
Imports are processed depending on the presence of the file: