-
Notifications
You must be signed in to change notification settings - Fork 6
Added shortcake UI plugin integration #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
includes/class-content-toc.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a good approach to include 3rd party plugins integrations?
|
I've noticed that if I specify element as I wonder if it adds P.S. this is might be due to the fact that other PR that deal with escaping regex isn't merge yet. Ignore this and I'll double check this again after another PR is merged :) Reference: Shortcake fixed it for 4.1, but it got broken again from 4.2 as WP made changes to MCE Views. wp-shortcake/shortcake#179 Update: Gonna leave this for now.. elements specified with |
… to let them know, not to use <> brakets
|
@dashaluna looks fine to me. May want to consider an admin notice about the shortcake requirement if it's not installed. |
|
@tcrsavage Hm, shortcake UI isn't a requirement really. It just does integration if that plugin is already present, otherwise it does nothing. I guess I can display a note saying if they know about shortcake and want to check it out... What do you think? |
…arly. Open WP plugin directory link in a new window
Added shortcake UI plugin integration
#1