Skip to content

Commit

Permalink
Merge bitcoin#15533: test: .style.yapf: Set column_limit=160
Browse files Browse the repository at this point in the history
1111f07 test: .style.yapf: Set column_limit=160 (MarcoFalke)

Pull request description:

  The current style is pep8, as suggested in https://github.com/bitcoin/bitcoin/blob/master/test/functional/README.md#style-guidelines.

  generated with

  ```
  $ yapf --version
  yapf 0.24.0
  $ yapf --style-help --style=pep8 > .style.yapf
  ```

  However, we don't use the column_limit of 79 right now. Practically it is somewhere between 120-240.

  Some stats:

  ```
  column_limit=120: 115 files changed, 2423 insertions(+), 1408 deletions(-)
  column_limit=160: 108 files changed, 1563 insertions(+), 1247 deletions(-)
  column_limit=200: 104 files changed, 1255 insertions(+), 1178 deletions(-)

ACKs for commit 1111f0:
  practicalswift:
    utACK 1111f07 agree with @ryanofsky
  ryanofsky:
    utACK 1111f07

Tree-SHA512: 1ce0da83b917496f4ea7d1af31b624517a78998a10091b6ba611737f2c819fa3cda1786307f15d20131a00fd95232818e3d1108950dd12b60c4674eaa447839f
  • Loading branch information
MarcoFalke authored and PastaPastaPasta committed Jul 10, 2021
1 parent b902736 commit dc25ff6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .style.yapf
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ blank_line_before_nested_class_or_def=False
coalesce_brackets=False

# The column limit.
column_limit=79
column_limit=160

# The style for continuation alignment. Possible values are:
#
Expand Down

0 comments on commit dc25ff6

Please sign in to comment.