feat(sdk): asset lock quorum and core locked height verification

packages/dapi-grpc/build.rs

@@ -63,94 +63,99 @@ fn configure_platform(mut platform: MappingConfig) -> MappingConfig {
     // Derive features for versioned messages
     //
     // "GetConsensusParamsRequest" is excluded as this message does not support proofs
-    const VERSIONED_REQUESTS: [&str; 40] = [
+    //
+    // Sort alphabetically to simplify maintenance.
+    const VERSIONED_REQUESTS: [&str; 41] = [
+        "GetContestedResourceIdentityVotesRequest",
+        "GetContestedResourcesRequest",
+        "GetContestedResourceVoteStateRequest",
+        "GetContestedResourceVotersForIdentityRequest",
         "GetDataContractHistoryRequest",
         "GetDataContractRequest",
         "GetDataContractsRequest",
         "GetDocumentsRequest",
+        "GetEpochsInfoRequest",
+        "GetEvonodesProposedEpochBlocksByIdsRequest",
+        "GetEvonodesProposedEpochBlocksByRangeRequest",
+        "GetGroupActionsRequest",
+        "GetGroupActionSignersRequest",
+        "GetGroupInfoRequest",
+        "GetGroupInfosRequest",
+        "GetIdentitiesBalancesRequest",
         "GetIdentitiesByPublicKeyHashesRequest",
+        "GetIdentitiesContractKeysRequest",
         "GetIdentitiesRequest",
-        "GetIdentitiesBalancesRequest",
-        "GetIdentityNonceRequest",
-        "GetIdentityContractNonceRequest",
+        "GetIdentitiesTokenBalancesRequest",
+        "GetIdentitiesTokenInfosRequest",
         "GetIdentityBalanceAndRevisionRequest",
         "GetIdentityBalanceRequest",
         "GetIdentityByPublicKeyHashRequest",
+        "GetIdentityContractNonceRequest",
         "GetIdentityKeysRequest",
+        "GetIdentityNonceRequest",
         "GetIdentityRequest",
+        "GetIdentityTokenBalancesRequest",
+        "GetIdentityTokenInfosRequest",
+        "GetPathElementsRequest",
+        "GetPrefundedSpecializedBalanceRequest",
         "GetProofsRequest",
-        "WaitForStateTransitionResultRequest",
         "GetProtocolVersionUpgradeStateRequest",
         "GetProtocolVersionUpgradeVoteStatusRequest",
-        "GetPathElementsRequest",
-        "GetIdentitiesContractKeysRequest",
-        "GetPrefundedSpecializedBalanceRequest",
-        "GetContestedResourcesRequest",
-        "GetContestedResourceVoteStateRequest",
-        "GetContestedResourceVotersForIdentityRequest",
-        "GetContestedResourceIdentityVotesRequest",
-        "GetVotePollsByEndDateRequest",
-        "GetTotalCreditsInPlatformRequest",
-        "GetEvonodesProposedEpochBlocksByIdsRequest",
-        "GetEvonodesProposedEpochBlocksByRangeRequest",
         "GetStatusRequest",
-        "GetIdentityTokenBalancesRequest",
-        "GetIdentitiesTokenBalancesRequest",
-        "GetIdentityTokenInfosRequest",
-        "GetIdentitiesTokenInfosRequest",
+        "GetTotalCreditsInPlatformRequest",
+        "GetVotePollsByEndDateRequest",
         "GetTokenStatusesRequest",
         "GetTokenTotalSupplyRequest",
-        "GetGroupInfoRequest",
-        "GetGroupInfosRequest",
-        "GetGroupActionsRequest",
-        "GetGroupActionSignersRequest",
+        "WaitForStateTransitionResultRequest",
     ];
 
     // The following responses are excluded as they don't support proofs:
     // - "GetConsensusParamsResponse"
     // - "GetStatusResponse"
     //
     //  "GetEvonodesProposedEpochBlocksResponse" is used for 2 Requests
+    //
+    // Sort alphabetically to simplify maintenance.
     const VERSIONED_RESPONSES: [&str; 39] = [
+        "GetContestedResourceIdentityVotesResponse",
+        "GetContestedResourcesResponse",
+        "GetContestedResourceVoteStateResponse",
+        "GetContestedResourceVotersForIdentityResponse",
         "GetDataContractHistoryResponse",
         "GetDataContractResponse",
         "GetDataContractsResponse",
         "GetDocumentsResponse",
-        "GetIdentitiesByPublicKeyHashesResponse",
-        "GetIdentitiesResponse",
-        "GetIdentitiesBalancesResponse",
+        "GetEpochsInfoResponse",
+        "GetEvonodesProposedEpochBlocksResponse",
+        "GetGroupActionsResponse",
+        "GetGroupActionSignersResponse",
+        "GetGroupInfoResponse",
+        "GetGroupInfosResponse",
         "GetIdentityBalanceAndRevisionResponse",
         "GetIdentityBalanceResponse",
-        "GetIdentityNonceResponse",
-        "GetIdentityContractNonceResponse",
         "GetIdentityByPublicKeyHashResponse",
+        "GetIdentityContractNonceResponse",
         "GetIdentityKeysResponse",
+        "GetIdentityNonceResponse",
         "GetIdentityResponse",
+        "GetIdentityTokenBalancesResponse",
+        "GetIdentityTokenInfosResponse",
+        "GetIdentitiesBalancesResponse",
+        "GetIdentitiesByPublicKeyHashesResponse",
+        "GetIdentitiesContractKeysResponse",
+        "GetIdentitiesResponse",
+        "GetIdentitiesTokenBalancesResponse",
+        "GetIdentitiesTokenInfosResponse",
+        "GetPathElementsResponse",
+        "GetPrefundedSpecializedBalanceResponse",
         "GetProofsResponse",
-        "WaitForStateTransitionResultResponse",
-        "GetEpochsInfoResponse",
         "GetProtocolVersionUpgradeStateResponse",
         "GetProtocolVersionUpgradeVoteStatusResponse",
-        "GetPathElementsResponse",
-        "GetIdentitiesContractKeysResponse",
-        "GetPrefundedSpecializedBalanceResponse",
-        "GetContestedResourcesResponse",
-        "GetContestedResourceVoteStateResponse",
-        "GetContestedResourceVotersForIdentityResponse",
-        "GetContestedResourceIdentityVotesResponse",
-        "GetVotePollsByEndDateResponse",
         "GetTotalCreditsInPlatformResponse",
-        "GetEvonodesProposedEpochBlocksResponse",
-        "GetIdentityTokenBalancesResponse",
-        "GetIdentitiesTokenBalancesResponse",
-        "GetIdentityTokenInfosResponse",
-        "GetIdentitiesTokenInfosResponse",
         "GetTokenStatusesResponse",
         "GetTokenTotalSupplyResponse",
-        "GetGroupInfoResponse",
-        "GetGroupInfosResponse",
-        "GetGroupActionsResponse",
-        "GetGroupActionSignersResponse",
+        "GetVotePollsByEndDateResponse",
+        "WaitForStateTransitionResultResponse",
     ];
 
     check_unique(&VERSIONED_REQUESTS).expect("VERSIONED_REQUESTS");

packages/rs-dapi-client/src/executor.rs

@@ -1,6 +1,7 @@
 use crate::transport::TransportRequest;
 use crate::{Address, CanRetry, DapiClientError, RequestSettings};
 use dapi_grpc::mock::Mockable;
+use dapi_grpc::platform::VersionedGrpcResponse;
 use dapi_grpc::tonic::async_trait;
 use std::fmt::Debug;
 
@@ -127,6 +128,22 @@ where
     }
 }
 
+impl<T: VersionedGrpcResponse> VersionedGrpcResponse for ExecutionResponse<T> {
+    type Error = T::Error;
+
+    fn metadata(&self) -> Result<&dapi_grpc::platform::v0::ResponseMetadata, Self::Error> {
+        self.inner.metadata()
+    }
+
+    fn proof(&self) -> Result<&dapi_grpc::platform::v0::Proof, Self::Error> {
+        self.inner.proof()
+    }
+
+    fn proof_owned(self) -> Result<dapi_grpc::platform::v0::Proof, Self::Error> {
+        self.inner.proof_owned()
+    }
+}
+
 /// Result of request execution
 pub type ExecutionResult<R, E> = Result<ExecutionResponse<R>, ExecutionError<E>>;
 

packages/rs-dpp/Cargo.toml

@@ -127,7 +127,7 @@ dash-sdk-features = [
   #  "json-object",
   #  "platform-value",
   #  "system_contracts",
-  # "validation", # TODO: This one is big
+  "validation",                    # TODO: This one is big
   "identity-hashing",
   "data-contract-json-conversion",
   #  "identity-serialization",

packages/rs-dpp/src/core_types/validator_set/v0/mod.rs

@@ -311,7 +311,7 @@ mod tests {
         let node_ip = "192.168.1.1".to_string();
         let node_id = PubkeyHash::from_slice(&[4; 20]).unwrap();
         let validator = ValidatorV0 {
-            pro_tx_hash: pro_tx_hash.clone(),
+            pro_tx_hash,
             public_key,
             node_ip,
             node_id,

packages/rs-drive-proof-verifier/src/provider.rs

@@ -91,7 +91,7 @@ impl<C: AsRef<dyn ContextProvider> + Send + Sync> ContextProvider for C {
     }
 }
 
-impl<'a, T: ContextProvider + 'a> ContextProvider for std::sync::Mutex<T>
+impl<T: ContextProvider> ContextProvider for std::sync::Mutex<T>
 where
     Self: Sync + Send,
 {

packages/rs-drive-proof-verifier/src/types/evonode_status.rs

@@ -241,7 +241,7 @@ impl TryFrom<&GetStatusResponse> for Version {
                 let protocol = v0
                     .version
                     .as_ref()
-                    .and_then(|v| v.protocol.clone())
+                    .and_then(|v| v.protocol)
                     .map(|p| Protocol {
                         tenderdash: p.tenderdash.map(|t| TenderdashProtocol {
                             p2p: t.p2p,

packages/rs-drive-proof-verifier/src/verify.rs

@@ -130,7 +130,7 @@ pub fn verify_signature_digest(
         });
     }
     let signature = Signature::Basic(
-        <Bls12381G2Impl as Pairing>::Signature::from_compressed(&signature)
+        <Bls12381G2Impl as Pairing>::Signature::from_compressed(signature)
             .into_option()
             .ok_or(Error::SignatureVerificationError {
                 error: "Could not verify signature digest".to_string(),

packages/rs-sdk/src/error.rs

@@ -55,6 +55,37 @@ pub enum Error {
     /// Epoch not found; we must have at least one epoch
     #[error("No epoch found on Platform; it should never happen")]
     EpochNotFound,
+    /// Quorum not found; try again later
+    #[error(
+        "Quorum {quorum_hash_hex} of type {quorum_type} at height {core_chain_locked_height}: {e}"
+    )]
+    QuorumNotFound {
+        quorum_hash_hex: String,
+        quorum_type: u32,
+        core_chain_locked_height: u32,
+        e: ContextProviderError,
+    },
+
+    /// Asset lock not found; try again later.
+    ///
+    /// ## Parameters
+    ///
+    /// - core locked height in asset lock
+    /// - current core locked height on the platform
+    #[error("Asset lock for core locked height {core_locked_height_in_asset_lock} not available yet, max available locked core height is {core_locked_height_on_platform}; try again later")]
+    CoreLockedHeightNotYetAvailable {
+        core_locked_height_in_asset_lock: u32,
+        core_locked_height_on_platform: u32,
+    },
+
+    /// Provided asset lock is invalid
+    ///
+    /// ## Parameters
+    ///
+    /// - 0 - detailed error message
+    #[error("Invalid asset lock: {0}")]
+    InvalidAssetLock(String),
+
     /// SDK operation timeout reached error
     #[error("SDK operation timeout {} secs reached: {1}", .0.as_secs())]
     TimeoutReached(Duration, String),
@@ -100,7 +131,7 @@ impl TryFrom<StateTransitionBroadcastErrorProto> for StateTransitionBroadcastErr
     type Error = Error;
 
     fn try_from(value: StateTransitionBroadcastErrorProto) -> Result<Self, Self::Error> {
-        let cause = if value.data.len() > 0 {
+        let cause = if !value.data.is_empty() {
             let consensus_error =
                 ConsensusError::deserialize_from_bytes(&value.data).map_err(|e| {
                     tracing::debug!("Failed to deserialize consensus error: {}", e);
@@ -178,7 +209,13 @@ where
 
 impl CanRetry for Error {
     fn can_retry(&self) -> bool {
-        matches!(self, Error::StaleNode(..) | Error::TimeoutReached(_, _))
+        matches!(
+            self,
+            Error::StaleNode(..)
+                | Error::TimeoutReached(_, _)
+                | Error::CoreLockedHeightNotYetAvailable { .. }
+                | Error::QuorumNotFound { .. }
+        )
     }
 }
 

packages/rs-sdk/src/platform/fetch_unproved.rs

@@ -89,7 +89,7 @@ where
                 Self::maybe_from_unproved_with_metadata(
                     request.clone(),
                     response,
-                    sdk.network,
+                    sdk.network(),
                     sdk.version(),
                 )
                 .map_err(|e| ExecutionError {

packages/rs-sdk/src/platform/query.rs

@@ -180,7 +180,7 @@ impl Query<proto::GetIdentityKeysRequest> for Identifier {
     }
 }
 
-impl<'a> Query<DocumentQuery> for DriveDocumentQuery<'a> {
+impl Query<DocumentQuery> for DriveDocumentQuery<'_> {
     fn query(self, prove: bool) -> Result<DocumentQuery, Error> {
         if !prove {
             unimplemented!("queries without proofs are not supported yet");

packages/rs-sdk/src/platform/transition.rs

@@ -1,7 +1,9 @@
 //! State transitions used to put changed objects to the Dash Platform.
+pub mod asset_lock;
 pub mod broadcast;
 pub(crate) mod broadcast_identity;
 pub mod broadcast_request;
+pub mod fungible_tokens;
 pub mod purchase_document;
 pub mod put_contract;
 pub mod put_document;
@@ -17,4 +19,3 @@ pub mod waitable;
 pub mod withdraw_from_identity;
 
 pub use txid::TxId;
-pub mod fungible_tokens;