-
Notifications
You must be signed in to change notification settings - Fork 44
feat(dashmate): add prometheus service discovery labels #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4e1c115
feat(dashmate): add prometheus service discovery labels
lklimek 208608b
fix: envoy metrics requires envoy admin
lklimek 62337dd
fix: rs-dapi metrics registered as port 0 when disabled
lklimek 57a0a67
doc: sample prometheus config
lklimek 1a6e248
doc: move prometheus docs to dashmate docs
lklimek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
packages/dashmate/test/unit/templates/dynamicCompose.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import HomeDir from '../../../src/config/HomeDir.js'; | ||
| import getBaseConfigFactory from '../../../configs/defaults/getBaseConfigFactory.js'; | ||
| import renderTemplateFactory from '../../../src/templates/renderTemplateFactory.js'; | ||
| import renderServiceTemplatesFactory from '../../../src/templates/renderServiceTemplatesFactory.js'; | ||
lklimek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| function getRsDapiBlock(dynamicComposeContent) { | ||
| const match = dynamicComposeContent.match(/rs_dapi:\n((?: {2}.*\n)+)/); | ||
| return match ? match[1] : ''; | ||
| } | ||
|
|
||
| describe('dynamic compose template', () => { | ||
| let getBaseConfig; | ||
| let renderServiceTemplates; | ||
|
|
||
| beforeEach(() => { | ||
| getBaseConfig = getBaseConfigFactory(HomeDir.createTemp()); | ||
| const renderTemplate = renderTemplateFactory(); | ||
| renderServiceTemplates = renderServiceTemplatesFactory(renderTemplate); | ||
| }); | ||
|
|
||
| it('should not publish metrics port when rs-dapi metrics are disabled', () => { | ||
| const config = getBaseConfig(); | ||
|
|
||
| const renderedConfigs = renderServiceTemplates(config); | ||
| const rsDapiBlock = getRsDapiBlock(renderedConfigs['dynamic-compose.yml']); | ||
|
|
||
| expect(rsDapiBlock).to.not.include('ports:'); | ||
| expect(rsDapiBlock).to.not.include(':0'); | ||
| }); | ||
|
|
||
| it('should publish metrics port when rs-dapi metrics are enabled', () => { | ||
| const config = getBaseConfig(); | ||
|
|
||
| config.set('platform.dapi.rsDapi.metrics.enabled', true); | ||
| config.set('platform.dapi.rsDapi.metrics.port', 29091); | ||
| config.set('platform.dapi.rsDapi.metrics.host', '127.0.0.1'); | ||
|
|
||
| const renderedConfigs = renderServiceTemplates(config); | ||
| const rsDapiBlock = getRsDapiBlock(renderedConfigs['dynamic-compose.yml']); | ||
|
|
||
| expect(rsDapiBlock).to.include('ports:\n - 127.0.0.1:29091:29091'); | ||
| expect(rsDapiBlock).to.include('- 29091'); | ||
| }); | ||
| }); | ||
24 changes: 24 additions & 0 deletions
24
packages/dashmate/test/unit/templates/envoyTemplate.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import getBaseConfigFactory from '../../../configs/defaults/getBaseConfigFactory.js'; | ||
| import HomeDir from '../../../src/config/HomeDir.js'; | ||
| import renderServiceTemplatesFactory from '../../../src/templates/renderServiceTemplatesFactory.js'; | ||
| import renderTemplateFactory from '../../../src/templates/renderTemplateFactory.js'; | ||
lklimek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| describe('envoy template', () => { | ||
| it('should render admin interface when metrics are enabled even if admin is disabled', () => { | ||
| const getBaseConfig = getBaseConfigFactory(HomeDir.createTemp()); | ||
| const config = getBaseConfig(); | ||
|
|
||
| config.set('platform.gateway.metrics.enabled', true); | ||
| config.set('platform.gateway.admin.enabled', false); | ||
|
|
||
| const renderTemplate = renderTemplateFactory(); | ||
| const renderServiceTemplates = renderServiceTemplatesFactory(renderTemplate); | ||
| const renderedConfigs = renderServiceTemplates(config); | ||
|
|
||
| const envoyConfig = renderedConfigs['platform/gateway/envoy.yaml']; | ||
|
|
||
| expect(envoyConfig).to.include('cluster_name: admin'); | ||
| expect(envoyConfig).to.include('address: 127.0.0.1'); | ||
| expect(envoyConfig).to.include('port_value: 9901'); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.