Skip to content

Remove expression.rs file and use Arrow DataFusion Python version #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 63 commits into
base: main
Choose a base branch
from
Draft

Remove expression.rs file and use Arrow DataFusion Python version #1139

wants to merge 63 commits into from

Conversation

jdye64
Copy link
Collaborator

@jdye64 jdye64 commented May 9, 2023

Remove local expression.rs file and use the one in Arrow DataFusion Python instead.

jdye64 and others added 30 commits April 12, 2023 20:29
@jdye64
Merge remote-tracking branch 'upstream/main'
fa18499
@jdye64
Merge remote-tracking branch 'upstream/main'
d6b470c
@jdye64
Merge remote-tracking branch 'upstream/main'
856f7c0
@jdye64
Remove local expression.rs file and refactor codebase to use datafusi…
0e8e96c 
…on_python version
@jdye64
Merge branch 'main' into drop_expr
f8b52f8
@jdye64
Fix issues from previous merge introduced
2cff5e0
@jdye64
Merge branch 'main' into drop_expr
29c48b6
@jdye64
Uncomment section for time types
065471e
@jdye64
Update to use Option<Arc<str>> and us unsafe Arc::from_raw() method
7a9906f
@jdye64
Use into() instead of unsafe Arc::from_raw()
3a7754d
@jdye64
partial refactoring checkpoint
435db42
@jdye64
bump arrow datafusion python version
daa0dcd
@jdye64
merge upstream/main
adaf7c1
@jdye64
Checkpoint, aggregations working
98938d9
@jdye64
Checkpoint, show and sort working
48fbc58
@jdye64
Merge branch 'main' into drop_expr
34ee9e3
@jdye64
Checkpoint, distributeby working and partial join
1464bf6
@jdye64
Checkpoint, window logic and pytest passing
1e94c01
@jdye64
checkpoint, test_schema.py tests all passing
25bc867
@jdye64
Merge remote-tracking branch 'upstream/main' into drop_expr
24350b5
@jdye64
Merge remote-tracking branch 'upstream/main'
4b86547
@jdye64
Merge remote-tracking branch 'upstream/main'
28fce59
@jdye64
Bump ADP -> 26.0.0
6637b84
@jdye64
warn on optimization failure instead of erroring and exiting
c59cdbd
@ayushdg
Merge branch 'main' into adp_26
79a1f7c
@ayushdg
Merge branch 'main' into adp_26
ba585a5
@charlesbluca
Merge remote-tracking branch 'origin/main' into adp_26
23af11d
@charlesbluca
Resolve initial build errors
5c02c5a
@charlesbluca
Merge remote-tracking branch 'origin/main' into adp_26
7c36bf5
@charlesbluca
Switch to crates release, add zlib to host/build deps
515dae6
jdye64 and others added 30 commits July 11, 2023 21:31
@jdye64
Bump to ADP 27 and introduce support for wildcard expressions, a wild…
6858578 
…card expression name will be subbed with the first column in the incoming schema plan
@jdye64
remove bit of logic that is no longer needed to manually check the wi…
24e0f90 
…ldcard 'name' as a '*'
@jdye64
experiment with removing zlib, hoping that fixes os x build
d776229
@jdye64
Change expected_df result to 1.5 from 1. 3/2 is in fact 1.5 and not 1
99ec801
@jdye64
Fix cargo test
8997f7f
@jdye64
merge with upstream ADP 27 bump PR
45b5f42
@jdye64
add .cargo/config.toml in hopes of fixing linker build issues on osx
ec1d2bf
@jdye64
add .cargo/config.toml in hopes of fixing linker build issues on osx
379a978
@charlesbluca
Remove extra config.toml
e030bef
@charlesbluca
Try overriding runner-installed toolchain
b2e85df
@charlesbluca
Revert "Try overriding runner-installed toolchain"
d01088d 
This reverts commit b2e85df.
@charlesbluca
Initial migration to maturin build system
ca70f0f
@charlesbluca
Make some modifications to Rust package name
d900f0e
@jdye64
Adjust native library name from _.internal to dask_planner
7d1be92
@charlesbluca
Resolve initial conda build issues
83fb5c3
@charlesbluca
Replace setuptools-rust with maturin in CI
c7bbbd7
@charlesbluca
Constrain maturin, remove setuptools-rust from CI envs
6dc6347
@charlesbluca
Update docs and Rust CI
6dcf5e0
@charlesbluca
Remove more dask_planner appearances
b7c02c9
@charlesbluca
Bump pyarrow min version to resolve 3.8 conflicts
a3e1a68
@jdye64
test commit seeing how CI will respond without cmd_loop import
3ff8240
@charlesbluca
Merge branch 'adp_26' of github.com:jdye64/dask-sql into adp_26
ce56a08
@charlesbluca
Rename module to _datafusion_lib
ae7a3d6
@charlesbluca
Switch to maturin develop for CI installs
0c2908c
@jdye64
Fix failing cargo tests, changed output, from datafusion version bump
849dc42
@jdye64
Fix cargo test syntax issue
1f73b56
Fix failing Rust tests
79b6eac
@jdye64
Remove linux config.toml options
405470f
@jdye64
Merge with upstream/adp_26 branch
ca5c093
@jdye64
Checkpoint commit
bdfad04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushdg ayushdg Awaiting requested review from ayushdg ayushdg will be requested when the pull request is marked ready for review ayushdg is a code owner

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca will be requested when the pull request is marked ready for review charlesbluca is a code owner

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar will be requested when the pull request is marked ready for review galipremsagar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdye64 @ayushdg @charlesbluca