Skip to content

Implement make_s_curve#967

Open
CC-Yeh wants to merge 2 commits intodask:mainfrom
CC-Yeh:add-make_s_curve
Open

Implement make_s_curve#967
CC-Yeh wants to merge 2 commits intodask:mainfrom
CC-Yeh:add-make_s_curve

Conversation

@CC-Yeh
Copy link

@CC-Yeh CC-Yeh commented Apr 2, 2023

Hi everyone,

I implemented a make_s_curve function and corresponding tests for it.

However, one of the tests is currently failing consistently, even though I have verified the values in the outputs and the computation graph. Appreciate any feedback or suggestions on how to resolve this issue.

The test that failed.

@pytest.mark.parametrize(
    "generator",
    [
        dask_ml.datasets.make_blobs,
        dask_ml.datasets.make_classification,
        dask_ml.datasets.make_counts,
        dask_ml.datasets.make_regression,
        dask_ml.datasets.make_s_curve,
    ],
)
def test_deterministic(generator, scheduler):
    a, t = generator(chunks=100, random_state=10)
    b, u = generator(chunks=100, random_state=10)
    assert_eq(a, b)
    assert_eq(t, u)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant