fix: replace absolute values in tailwind classes with relative ones #36
fix: replace absolute values in tailwind classes with relative ones #36dastarruer merged 2 commits intomasterfrom
Conversation
📝 WalkthroughWalkthroughThree Svelte UI components in app/src/lib/components/data-layers had Tailwind class values normalized: arbitrary pixel-based utilities were replaced with standard Tailwind utility classes and CSS variable reference syntax was adjusted. No public API or exported declarations were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/lib/components/data-layers/Separator.svelte`:
- Line 7: Replace the invalid custom width calc in the class on
Separator.svelte: remove w-[calc(100%-30px)] and use Tailwind spacing instead
(for example replace with w-full mx-[15px] or another appropriate Tailwind
margin like mx-4/mx-8) so the separator takes full width with side margins
rather than a broken calc; update the class string that currently contains
w-[calc(100%-30px)] (and keep the existing h-px and opacity classes) to use
w-full plus the chosen mx-* utility.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b4b9c956-1d73-43ae-8d67-20c02bf1e613
📒 Files selected for processing (3)
app/src/lib/components/data-layers/LayerScrollArea.svelteapp/src/lib/components/data-layers/LayerSwitch.svelteapp/src/lib/components/data-layers/Separator.svelte
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/lib/components/data-layers/Separator.svelte`:
- Line 5: Tailwind arbitrary value syntax is invalid: replace occurrences like
bg-(--text) with the correct Tailwind form bg-[var(--text)]; update the
Separator.Root class string (Separator.Root decorative={true} ... bg-(--text) →
bg-[var(--text)]) and make the same replacement for other components that use
CSS vars (e.g., LayerSwitch and LayerScrollArea) such as bg-(--bg-alt) →
bg-[var(--bg-alt)] and bg-(--primary) → bg-[var(--primary)] so Tailwind
generates the expected utilities.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8480576d-1017-4a63-a468-384dd1e6383b
📒 Files selected for processing (1)
app/src/lib/components/data-layers/Separator.svelte
Closes #33
Summary by CodeRabbit