Skip to content

Fixed constant request to the server as the user types into the editor #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muhammedjafer wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixed constant request to the server as the user types into the editor #14

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbc6c52
fixed constant request to server as the user types into the editor, a…
muhammedjafer May 1, 2024
94e05a0
removed the toolbar option for the editor
muhammedjafer May 1, 2024
665aac6
Added readonly option for the editor
muhammedjafer May 15, 2024
25aae13
Adding readonly option for the editor
muhammedjafer May 15, 2024
8cc6905
Merge branch 'dasundev:main' into main
muhammedjafer May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions resources/views/livewire/quill-text-editor.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,27 @@
quill.root.innerHTML = $wire.get('value');
quill.on('text-change', function () {
let value = quill.root.innerHTML;
@this.set('value', value);
let timeout = null;
function handleTextChange() {
if (timeout !== null) {
clearTimeout(timeout);
}
timeout = setTimeout(function() {
Copy link
Owner

@dasundev dasundev May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the best way to handle this.

Copy link
Contributor Author

@muhammedjafer muhammedjafer May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why??

Copy link
Owner

@dasundev dasundev May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you are using a timeout.

Copy link

@ghabriel25 ghabriel25 Oct 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dasundev Just use lodash debounce

quill.on('text-change', _.debounce( () => {
    let value = quill.root.innerHTML;
    @this.set('value', value);
}, 1000));

lodash comes along with quill

let value = quill.root.innerHTML;
@this.set('value', value);
}, 1000);
}
quill.on('text-change', function() {
handleTextChange();
});
quill.on('selection-change', function() {
if (quill.hasFocus()) {
handleTextChange();
}
});
</script>
@endscript