feat!: apply type promotion rules according to the device context#889
Merged
kgryte merged 2 commits intodata-apis:mainfrom Feb 6, 2025
Merged
feat!: apply type promotion rules according to the device context#889kgryte merged 2 commits intodata-apis:mainfrom
kgryte merged 2 commits intodata-apis:mainfrom
Conversation
kgryte
commented
Feb 6, 2025
Contributor
Author
|
As this was previously discussed during workgroup meetings, I'll go ahead and merge. If any further changes and clarifications are necessary, we can address in follow-up PRs. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
result_typeandcan_cast. As not all devices can support all data types, both functions need to explicitly account for whether an array or dtype can be cast and/or promoted to a desired dtype on a given device.result_type, if two or more array arguments belong to separate devices, behavior is left unspecified and thus implementation-dependent.