add dataframe property#110
Conversation
rgommers
left a comment
There was a problem hiding this comment.
Thanks Marco. One question: isn't it better to type "returns unknown object" with -> Any rather than -> object?
|
from typing import *
class Animal:
def foo(self) -> object:
...
class Cat(Animal):
def foo(self) -> int:
return 3
reveal_type(Cat().foo())type checks fine, and would error on |
|
Ah fair enough. I haven't seen |
rgommers
left a comment
There was a problem hiding this comment.
This seems straightforward enough and the one minor concern on typing was answered - in it goes. Thanks @MarcoGorelli
closes #108