-
Notifications
You must be signed in to change notification settings - Fork 21
Add a way to retrieve the standard-compliant namespace, fill "how to adopt" and "future evolution" #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Taken over from the array API standard approach
Also largely taken over from the array API standard, with changes for the process and the smaller scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
to be able to define concat
as a function, rather than as a dataframe method, could we also add something like a spec/API_specification/dataframe_api/namespace.py
file in which to define functions such as concat
?
You can add content to |
This got two approvals and no unaddressed comments, so I'll hit the green button here. |
approach to check for compliance is by checking whether a dataframe object has | ||
an `__dataframe_namespace__` attribute, as this is the one distinguishing | ||
feature of a dataframe-compliant object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #115 (comment) you mentioned having this attribute on a non-compliant DataFrame object, as a way to go from that to a compliant one (unless I misunderstood the comment), which would not make this a fully correct check.
In general, this pathway seems missing in the current description? Assume you have written a function to work with a spec compliant dataframe API, is it then up to the user of your library to only pass such dataframes, or do we want a way that the function can check for any dataframe input if it can give in a compliant version of itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thanks Joris. We already have DataFrame.dataframe
to get back out the user-facing/non-compliant one, but we indeed do need to add the conversion the other way.
Let me open a follow-up issue right now, since I won't get to fixing that up today.
All this is taken over from the array API standard, where the approach is now stable and the kinks have been worked out.
Closes gh-115
Closes gh-79