Skip to content

[PLUGIN-1931] Add necessary condition to prevent query job when appropriate parameters are empty#1584

Merged
adrikagupta merged 1 commit intodevelopfrom
fix-generate-query
Oct 1, 2025
Merged

[PLUGIN-1931] Add necessary condition to prevent query job when appropriate parameters are empty#1584
adrikagupta merged 1 commit intodevelopfrom
fix-generate-query

Conversation

@adrikagupta
Copy link
Contributor

@adrikagupta adrikagupta commented Oct 1, 2025

In previous version, if a user provided no filters, no limits, and no partition dates, the code would still execute the full logic, only to determine at the end that the query should default to reading the source table directly (select * from "table") and creates a temporary table. But in such cases, there is no need to create a temporary table. Hence, added this check.

Testing:

  1. Created a pipeline with BQ source plugin using a table having required partitioning filter as true. Provided no filter, partitioning inputs, limit or order by clauses. The preview/deployment run is successful.
  2. Created a pipeline with BQ source plugin using a table having required partitioning filter as true. Provided filter, but no partitioning inputs, limit or order by clauses. The preview/deployment run is successful.
  3. Created a pipeline with BQ source plugin using a table having required partitioning filter as false. Provided no filter, partitioning inputs, limit or order by clauses. The preview/deployment run is successful.
  4. Created a pipeline with BQ source plugin using a table having required partitioning filter as false. Provided filter, limit but no partitioning inputs, order by clauses. The preview/deployment run is successful.

@adrikagupta adrikagupta added the build Trigger unit test build label Oct 1, 2025
Copy link
Contributor

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add PR description on what does this change do, how is it tested.

@adrikagupta adrikagupta merged commit 63524d1 into develop Oct 1, 2025
16 checks passed
@adrikagupta adrikagupta deleted the fix-generate-query branch October 1, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Trigger unit test build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants