[PLUGIN-1931] Add necessary condition to prevent query job when appropriate parameters are empty#1584
Merged
adrikagupta merged 1 commit intodevelopfrom Oct 1, 2025
Merged
Conversation
8d550b4 to
2b5de92
Compare
Contributor
itsankit-google
left a comment
There was a problem hiding this comment.
Please add PR description on what does this change do, how is it tested.
src/test/java/io/cdap/plugin/gcp/bigquery/source/PartitionedBigQueryInputFormatTest.java
Outdated
Show resolved
Hide resolved
2b5de92 to
b9f3014
Compare
src/main/java/io/cdap/plugin/gcp/bigquery/source/PartitionedBigQueryInputFormat.java
Show resolved
Hide resolved
itsankit-google
approved these changes
Oct 1, 2025
This was referenced Oct 1, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous version, if a user provided no filters, no limits, and no partition dates, the code would still execute the full logic, only to determine at the end that the query should default to reading the source table directly (select * from "table") and creates a temporary table. But in such cases, there is no need to create a temporary table. Hence, added this check.
Testing: