[PLUGIN-1856] Error management for Wrangler plugin#726
Merged
psainics merged 1 commit intodata-integrations:developfrom Feb 12, 2025
Merged
[PLUGIN-1856] Error management for Wrangler plugin#726psainics merged 1 commit intodata-integrations:developfrom
psainics merged 1 commit intodata-integrations:developfrom
Conversation
df84fa4 to
b70d696
Compare
f48259e to
97fa44c
Compare
psainics
reviewed
Jan 29, 2025
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerUtil.java
Outdated
Show resolved
Hide resolved
psainics
reviewed
Jan 29, 2025
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerUtil.java
Outdated
Show resolved
Hide resolved
a54195a to
d46f401
Compare
psainics
reviewed
Jan 29, 2025
wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java
Outdated
Show resolved
Hide resolved
psainics
reviewed
Jan 29, 2025
psainics
reviewed
Jan 29, 2025
335bb68 to
1e04c2d
Compare
psainics
reviewed
Jan 29, 2025
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerUtil.java
Outdated
Show resolved
Hide resolved
psainics
reviewed
Jan 29, 2025
wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java
Outdated
Show resolved
Hide resolved
be7d0f8 to
645593d
Compare
psainics
reviewed
Jan 29, 2025
wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java
Outdated
Show resolved
Hide resolved
psainics
reviewed
Jan 29, 2025
wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java
Outdated
Show resolved
Hide resolved
psainics
reviewed
Jan 29, 2025
wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java
Outdated
Show resolved
Hide resolved
fa9723f to
b7da1fe
Compare
Contributor
|
E2E Fixed in #727 ! |
06a92fa to
ff4f0d5
Compare
psainics
reviewed
Jan 30, 2025
wrangler-transform/src/test/java/io/cdap/wrangler/PreconditionTest.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerUtil.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java
Outdated
Show resolved
Hide resolved
cea6585 to
154f858
Compare
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java
Outdated
Show resolved
Hide resolved
cb50c30 to
5465f7e
Compare
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java
Outdated
Show resolved
Hide resolved
55b7dc1 to
5e7fd44
Compare
wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java
Outdated
Show resolved
Hide resolved
wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java
Outdated
Show resolved
Hide resolved
| if (!Feature.WRANGLER_PRECONDITION_SQL.isEnabled(relationalTranformContext)) { | ||
| throw new RuntimeException("SQL Precondition feature is not available"); | ||
| String errorReason = "SQL Precondition feature is not available"; | ||
| throw WranglerErrorUtil.getProgramFailureExceptionDetailsFromChain(null, errorReason, |
Contributor
There was a problem hiding this comment.
similar comment here
Contributor
There was a problem hiding this comment.
Also this method is private, how was it tested?
wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java
Outdated
Show resolved
Hide resolved
itsankit-google
approved these changes
Feb 11, 2025
0293f11 to
7b4619d
Compare
7b4619d to
f26ecd2
Compare
Vishwash123
pushed a commit
to Vishwash123/wrangler
that referenced
this pull request
Apr 13, 2025
…formPlugin [PLUGIN-1856] Error management for Wrangler plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://cdap.atlassian.net/browse/PLUGIN-1856
[ { "stageName": "Wrangler", "errorCategory": "Plugin-'Wrangler'", "errorReason": "Error in stage 'Wrangler'. Format of output schema specified is invalid. Please check the format. com.google.gson.stream.MalformedJsonException: Unterminated object at line 3 column 4 path $.type", "errorMessage": "Error in stage 'Wrangler'. Format of output schema specified is invalid. Please check the format. com.google.gson.stream.MalformedJsonException: Unterminated object at line 3 column 4 path $.type", "errorType": "USER", "dependency": "false" } ]