Skip to content

Fix and Refactor Wallet Balance Logic for Lotus Integration and Troubleshooting #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Fix and Refactor Wallet Balance Logic for Lotus Integration and Troubleshooting #556

wants to merge 2 commits into from

Conversation

Sankara-Jefferson
Copy link
Collaborator

Description:
This PR updates and refactors the wallet and handler logic to improve troubleshooting and integration with Lotus for wallet balance queries. Key changes include:

  • Refactored [testutil.go]to ensure test mocks do not interfere with CLI or integration runs, allowing real Lotus balance queries when required.
  • Updated wallet handler and CLI logic to better support the --with-balance flag, ensuring balances are fetched from Lotus when API and token are provided.
  • Improved error handling and documentation in wallet-related commands and handlers.
  • Updated and clarified CLI documentation for wallet commands, including usage of the --with-balance flag and Lotus API requirements.
  • Added and updated tests to cover edge cases and integration scenarios for wallet balance retrieval.
  • Excluded sensitive or user-specific files (e.g., my_keys.txt) from the commit.
    This PR is intended to:
  • Enable more reliable troubleshooting of Lotus integration issues.
  • Allow balances to be displayed for real addresses when running the CLI with the correct Lotus API and token.
  • Prepare the codebase for further debugging and improvements related to wallet and Lotus connectivity.

How to test:

  • Run singularity wallet list --with-balance --lotus-api <API_URL> --lotus-token to verify balances are fetched from Lotus.
  • Run the test suite to ensure all wallet and handler tests pass.
  • Review updated documentation for clarity on wallet command usage.

Jefferson Sankara added 2 commits July 16, 2025 16:55
chore: update wallet and handler logic for Lotus balance troubleshooting
ce5be9c
feat: Add database support improvements and wallet balance debugging
32e89e5 
- Add modernc SQLite driver support
- Improve database connection string handling
- Update wallet balance and list functionality
- Add build specific file for darwin
- Update dependencies in go.mod and go.sum
@Sankara-Jefferson Sankara-Jefferson marked this pull request as draft July 21, 2025 04:34
@ianconsolata
Copy link
Collaborator

What's the status of this draft PR? Is there still a plan to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sankara-Jefferson @ianconsolata