chore(test): add ut for type check #17680
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: coldWater <[email protected]>
github-actions
bot
added
the
pr-chore
forsaken628
commented
Apr 1, 2025
Signed-off-by: coldWater <[email protected]>
forsaken628
force-pushed
the
type_check_test
branch
from
019174f to
117f803
Compare
forsaken628
commented
Apr 1, 2025
|
|
||
| ast : d128 = '1' | ||
| raw expr : eq(d128::Decimal(38, 0), '1') | ||
| checked expr : eq<Float64, Float64>(to_float64<Decimal(38, 0)>(d128), to_float64<String>("1")) |
There was a problem hiding this comment.
The implicit type conversion rules are a bit inconsistent here.
Why d128 = '1' is allowed but d128 > '1' is not. and should not cast to Float64
Signed-off-by: coldWater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is