Skip to content

fix(query): Some environment variable configurations do not work #18384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2025
Merged

fix(query): Some environment variable configurations do not work #18384

merged 3 commits into from
Jul 29, 2025
+24 −14

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Jul 18, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

also see datafuse-extras/serfig@610ac6d

It seems to be because the configuration name contains underscores

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jul 18, 2025
@forsaken628 forsaken628 requested a review from Xuanwo July 18, 2025 04:23
@forsaken628
Copy link
Collaborator Author

@Xuanwo please take a look

@forsaken628 forsaken628 requested review from sundy-li and removed request for Xuanwo July 28, 2025 06:19
@forsaken628 forsaken628 marked this pull request as ready for review July 28, 2025 09:00
@sundy-li sundy-li added the ci-cloud Build docker image for cloud test label Jul 29, 2025
@sundy-li sundy-li added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jul 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-18384-0a28c95-1753762581

note: this image tag is only available for internal use.

@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-18384-01e6eb9-1753762654

note: this image tag is only available for internal use.

@sundy-li sundy-li merged commit 3075b0a into databendlabs:main Jul 29, 2025
113 of 115 checks passed
@forsaken628 forsaken628 deleted the env-config branch July 30, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forsaken628 @sundy-li