[Fix] type issue in databricks_sql_table
#4422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore then one word in a string
ian-norris-ncino
requested review from
parthban-db
and removed request for
a team
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
alexott
changed the title
databricks_sql_tabledatabricks_sql_table
alexott
requested changes
Jan 22, 2025
| @@ -540,10 +540,11 @@ var columnTypeAliases = map[string]string{ | |||
|
|
|||
| func getColumnType(columnType string) string { | |||
| caseInsensitiveColumnType := strings.ToLower(columnType) | |||
| if alias, ok := columnTypeAliases[caseInsensitiveColumnType]; ok { | |||
| normalizedColumnType := strings.Split(caseInsensitiveColumnType, " ")[0] | |||
There was a problem hiding this comment.
Can we strip spaces from the string? Just to avoid the potential problem when a user puts a space into type?
Can we also add a unit test for this function? It will detect code problems earlier, without need to run a full integration test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated type check to only compare the first word in the type string.
Tests
make testrun locallydocs/folderinternal/acceptance