Skip to content

Fix stale reference of deleted dataset table #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −0
Draft

Fix stale reference of deleted dataset table #1468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6d8a7e
fixing delete dataset
ilongin Nov 20, 2025
6ab2206
removed not needed code
ilongin Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/datachain/data_storage/sqlite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,9 @@ def create_table(

def drop_table(self, table: "Table", if_exists: bool = False) -> None:
self.execute(DropTable(table, if_exists=if_exists))
# Remove the table from metadata to avoid stale references
if table.name in self.metadata.tables:
self.metadata.remove(self.metadata.tables[table.name])

def rename_table(self, old_name: str, new_name: str):
comp_old_name = quote_schema(old_name)
Expand Down
8 changes: 8 additions & 0 deletions tests/unit/lib/test_datachain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4537,3 +4537,11 @@ class Signal2(DataModel):
assert chain.max("signals.signal.i3") == 15
assert chain.max("signals.signal.f3") == 7.5
assert chain.max("signals.signal.s3") == "eee"


def test_delete_dataset_and_create_with_same_name(test_session):
chain = dc.read_values(num=[1, 2, 3], session=test_session)
chain.save("nums")
dc.delete_dataset("nums", force=True, session=test_session)
chain.save("nums")
assert "nums" in dc.datasets(session=test_session).to_values("name")
Loading