feat: improve date parsing - #245
Open
ThibaudDauce wants to merge 18 commits into
Open
Conversation
ThibaudDauce
force-pushed
the
improve_date_parsing
branch
from
April 8, 2026 11:59
0f8d074 to
ab90678
Compare
# Conflicts: # csv_detective/detection/formats.py # csv_detective/parsing/columns.py # csv_detective/validate.py # tests/test_fields.py
…ns, optional format parts
|
A necessary change! The logic looks good, but I need to take more time to review all changes more carefully :) |
bolinocroustibat
approved these changes
Aug 20, 2026
bolinocroustibat
left a comment
Contributor
There was a problem hiding this comment.
LGTM, with two remarks
There was a problem hiding this comment.
Here, unsure why do we drop this format ? Because not an known separate format and this can be included in date.py just as a type of date format like any other ?
[the comment was for the deleted date_fr file, not appearing on the right one here + this has been managed since by commit 48219e8]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace fix: cast dd/mm/yyyy dates day-first (was silently swapping day and month) #268
add
date_formatto profile to have a faster cast in hydraby finding a unique date format for the column it prevent having US dates (month first) vs FR dates (day first) mixed
date_fris removed,datereads the same values and gives them a realdatepython_type. Stored analyses naming it still validate, nothing to regenerate.hydra stats (require perf: cast dates with the format inferred by csv-detective hydra#470):
Some analyses will be invalidated and replayed after the merge. Values
dateutilused to read as dates and that we don't detect anymore, on the files I have locally:D. 2.9 ; E. 0.6M 1089134,13848.8256130680428426202501010000Everything but the last one is noise
dateutilwas finding in phone numbers, latitudes and museum inventory numbers.AAAAMMJJHHMNis a real one: it's nowdatetime_naivewhere it wasdate, so the column type changes in the db (it holds hours and minutes that thedatetype was dropping).