fix: grant session-runner permission to update tasks/status#127
Conversation
The kelos-session-runner service account was missing RBAC permission to update the tasks/status subresource, causing task status updates to fail in session pods. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Greptile SummaryThis PR adds the missing
Confidence Score: 5/5Safe to merge — single RBAC rule addition that unblocks a known runtime failure without granting any broad or unexpected permissions. The change adds three verbs (get, patch, update) on the tasks/status subresource to the session-runner role, exactly matching the pattern used by sibling roles. The scope is narrow and the fix directly corresponds to the documented forbidden error. No other parts of the system are touched. No files require special attention.
|
Align with the pattern used by kelos-controller-role and kelos-spawner-role. The get verb is needed for the retry loop in updateTaskStatus, and patch matches sibling roles. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
@greptile Review and update Greptile Summary. |
tmarshall
left a comment
There was a problem hiding this comment.
i'll approve to unblock, but hans can share thoughts when he's back online
|
ah, forgot this slack comment from hans: https://anomalo-ai.slack.com/archives/C0ANDBX8H6F/p1777660492229529
we can leave this change in, since we already landed it, but a heads up for next time |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The
kelos-session-runnerservice account was missing RBAC permission to update thetasks/statussubresource. This caused session pods to fail with:This PR adds the missing
updateverb ontasks/statusto the session-runner ClusterRole.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Single RBAC rule addition — no other changes.
Does this PR introduce a user-facing change?