Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion/grafana): Add datasets and charts to dashboards with lineage and tags. Lineage back to source #12417
base: master
Are you sure you want to change the base?
feat(ingestion/grafana): Add datasets and charts to dashboards with lineage and tags. Lineage back to source #12417
Changes from 8 commits
d4be2de
660daf8
6cfbf5f
23e4eca
5468909
e684eed
eda52c4
507c811
0e9f0dc
c832e91
0fe68d2
c0e63d7
64a3bae
09b1ed8
b06fd12
e0533ad
27a9ceb
a7e9e19
4714b24
f0f88c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 3 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L3
Check warning on line 6 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L5-L6
Check warning on line 15 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L15
Check warning on line 18 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L17-L18
Check warning on line 23 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L20-L23
Check warning on line 25 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L25
Check warning on line 28 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L28
Check warning on line 31 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L30-L31
Check warning on line 35 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L33-L35
Check warning on line 39 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L37-L39
Check warning on line 45 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L42-L45
Check warning on line 47 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L47
Check warning on line 49 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L49
Check warning on line 57 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L57
Check warning on line 60 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L60
Check warning on line 63 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L62-L63
Check warning on line 65 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L65
Check warning on line 74 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L74
Check warning on line 79 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L76-L79
Check warning on line 85 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L81-L85
Check warning on line 87 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L87
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that split by
,
will actually split by columns may be wrong assumption,eg
:SELECT CONCAT(first_name, ' ', last_name) AS full_name FROM users
Not sure if we need to address this complexity though. WDYT?
Check warning on line 91 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L89-L91
Check warning on line 99 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L98-L99
Check warning on line 101 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L101
Check warning on line 104 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L104
Check warning on line 107 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L106-L107
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we log some warning here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put this in logger but were you looking for this to be in the report?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger should be fine
given we are catching three types of exceptions, adding the exception to the log trace may help to discriminate the issue
Check warning on line 109 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L109
Check warning on line 118 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L118
Check warning on line 120 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L120
Check warning on line 127 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L123-L127
Check warning on line 130 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L130
Check warning on line 133 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L133
Check warning on line 135 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L135
Check warning on line 138 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L138
Check warning on line 140 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L140
Check warning on line 145 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L143-L145
Check warning on line 159 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L154-L159
Check warning on line 167 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L167
Check warning on line 170 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L170
Check warning on line 174 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L174
Check warning on line 179 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L176-L179
Check warning on line 187 in metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py
metadata-ingestion/src/datahub/ingestion/source/grafana/field_utils.py#L187
Check warning on line 4 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L3-L4
Check warning on line 8 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L6-L8
Check warning on line 11 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L10-L11
Check warning on line 13 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L13
Check warning on line 16 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L16
Check warning on line 19 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L19
Check warning on line 29 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L26-L29
Check warning on line 33 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L31-L33
Check warning on line 40 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L40
Check warning on line 44 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L43-L44
Check warning on line 46 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L46
Check warning on line 48 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L48
Check warning on line 50 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L50
Check warning on line 57 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L52-L57
Check warning on line 61 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L61
Check warning on line 63 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L63
Check warning on line 70 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L65-L70
Check warning on line 75 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L75
Check warning on line 77 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L77
Check warning on line 81 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L79-L81
Check warning on line 87 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L83-L87
Check warning on line 91 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L89-L91
Check warning on line 95 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_api.py#L95
Check warning on line 1 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L1
Check warning on line 3 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L3
Check warning on line 7 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L5-L7
Check warning on line 10 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L10
Check warning on line 13 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L13
Check warning on line 20 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L16-L20
Check warning on line 23 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two may be removed if using
PlatformInstanceConfigMixin
andEnvConfigMixin
inGrafanaSourceConfig
, are they really needed atPlatformConnectionConfig
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the to use the parent class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platform_instance
andenv
still there as well asplatform_instance
inGrafanaSourceConfig
🤔what parent class do you refer to?
Check warning on line 26 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L26
Check warning on line 30 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L29-L30
Check warning on line 34 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L33-L34
Check warning on line 38 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L38
Check warning on line 42 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L42
Check warning on line 46 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L46
Check warning on line 49 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L49
Check warning on line 53 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L53
Check warning on line 57 in metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py
metadata-ingestion/src/datahub/ingestion/source/grafana/grafana_config.py#L55-L57