feat(ingestion/mongodb) re-order aggregation logic #12428
+4,615
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an unnecessary comma in the MongoDB aggregation logic to ensure consistency in the code style. This change does not affect functionality but improves code readability.
Refactor the MongoDB document aggregation process by consolidating the aggregation call into a single location, regardless of the sample size condition. This change enhances code clarity and maintains functionality.
Refactor the MongoDB document aggregation logic to streamline the handling of sampling conditions. The changes ensure that the aggregation process is clearer by consolidating the logic for random sampling and limiting sample size into a more cohesive structure, enhancing code readability while maintaining existing functionality.
Reorganize the logic for adding a document size filter in the MongoDB aggregation process. The changed aggregation order improves MongoDB scanning performance.
github-actions
bot
added
ingestion
Codecov ReportAll modified and coverable lines are covered by tests ✅
Continue to review full report in Codecov by Sentry.
|
datahub-cyborg
bot
added
the
needs-review
Haebuk
changed the title
…ndom sampling - Introduced a new golden JSON file for MongoDB ingestion without random sampling. - Updated the test suite to include a pipeline that verifies the ingestion process. - Ensured the output is validated against the new golden file to maintain data integrity. This commit enhances the testing framework for MongoDB ingestion, ensuring that the functionality works as expected without random sampling.
| @@ -218,26 +218,25 @@ def construct_schema_pymongo( | |||
| """ | |||
|
|
|||
| aggregations: List[Dict] = [] | |||
|
|
|||
There was a problem hiding this comment.
So the order of the aggregations impacts execution time. By setting the sample/limit aggregation first, the subsequent aggregations process a much smaller dataset. Is my understanding correct? Could you add a brief code comment to highlight this?
datahub-cyborg
bot
added
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fix the linked issue by reordering aggregation logics.
It would be sampling first then measuring doc size and filtering so much faster.
Checklist
should_add_document_size_filter#12427