Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(powerbi): Make report & chart patterns configurable for PowerBIReportServer #12435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Jan 22, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@sgomezvillamor sgomezvillamor changed the title fix(powerbi report server) Make report & chart patterns configurable fix(powerbi): Make report & chart patterns configurable for PowerBIReportServer Jan 22, 2025
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 22, 2025
Comment on lines +118 to +125
report_pattern: AllowDenyPattern = pydantic.Field(
default=AllowDenyPattern.allow_all(),
description="Regex patterns to filter PowerBI Reports in ingestion.",
)
chart_pattern: AllowDenyPattern = pydantic.Field(
default=AllowDenyPattern.allow_all(),
description="Regex patterns to filter PowerBI Charts in ingestion.",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not wrong, these two patterns are not used anywhere and so the feature actually requires further work.

Whether they were added as a sort of TODO or not, I don't know 🤔

Copy link

codecov bot commented Jan 22, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3441 1 3440 66
View the top 1 failed tests by shortest run time
tests.integration.kafka.test_kafka_state::test_kafka_ingest_with_stateful
Stack Traces | 122s run time
docker_compose_runner = <function docker_compose_runner.<locals>.run at 0x7f1e600b75f0>
pytestconfig = <_pytest.config.Config object at 0x7f1eda45ba80>
tmp_path = PosixPath('.../pytest-of-runner/pytest-0/test_kafka_ingest_with_statefu0')
mock_time = None
mock_datahub_graph = <MagicMock spec='DataHubGraph' id='139768436798768'>

    @freeze_time(FROZEN_TIME)
    @pytest.mark.integration
    def test_kafka_ingest_with_stateful(
        docker_compose_runner, pytestconfig, tmp_path, mock_time, mock_datahub_graph
    ):
        test_resources_dir = pytestconfig.rootpath / "tests/integration/kafka"
        topic_prefix: str = "stateful_ingestion_test"
        topic_names: List[str] = [f"{topic_prefix}_t1", f"{topic_prefix}_t2"]
        platform_instance = "test_platform_instance_1"
    
        with docker_compose_runner(
            test_resources_dir / "docker-compose.yml", "kafka"
        ) as docker_services:
>           wait_for_port(docker_services, "test_broker", KAFKA_PORT, timeout=120)

.../integration/kafka/test_kafka_state.py:94: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.../datahub/testing/docker_utils.py:36: in wait_for_port
    docker_services.wait_until_responsive(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = Services(_docker_compose=DockerComposeExecutor(_compose_command='docker compose', _compose_files=[PosixPath('/home/run...adata.../integration/kafka/docker-compose.yml')], _compose_project_name='pytest4667-kafka'), _services={})
check = <function wait_for_port.<locals>.<lambda> at 0x7f1e600b6f10>
timeout = 120, pause = 0.5, clock = <built-in function perf_counter>

    def wait_until_responsive(
        self,
        check: Any,
        timeout: float,
        pause: float,
        clock: Any = timeit.default_timer,
    ) -> None:
        """Wait until a service is responsive."""
    
        ref = clock()
        now = ref
        while (now - ref) < timeout:
            if check():
                return
            time.sleep(pause)
            now = clock()
    
>       raise Exception("Timeout reached while waiting on service!")
E       Exception: Timeout reached while waiting on service!

venv/lib/python3.11.../site-packages/pytest_docker/plugin.py:120: Exception

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants