-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(powerbi): Make report & chart patterns configurable for PowerBIReportServer #12435
Open
pedro93
wants to merge
1
commit into
master
Choose a base branch
from
ps-powerbi-report-server-improvement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgomezvillamor
changed the title
fix(powerbi report server) Make report & chart patterns configurable
fix(powerbi): Make report & chart patterns configurable for PowerBIReportServer
Jan 22, 2025
github-actions
bot
added
the
ingestion
PR or Issue related to the ingestion of metadata
label
Jan 22, 2025
Comment on lines
+118
to
+125
report_pattern: AllowDenyPattern = pydantic.Field( | ||
default=AllowDenyPattern.allow_all(), | ||
description="Regex patterns to filter PowerBI Reports in ingestion.", | ||
) | ||
chart_pattern: AllowDenyPattern = pydantic.Field( | ||
default=AllowDenyPattern.allow_all(), | ||
description="Regex patterns to filter PowerBI Charts in ingestion.", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not wrong, these two patterns are not used anywhere and so the feature actually requires further work.
Whether they were added as a sort of TODO or not, I don't know 🤔
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
datahub-cyborg
bot
added
the
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
label
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ingestion
PR or Issue related to the ingestion of metadata
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist