Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(powerbi): Report to Dashboard lineage #12451

Open
wants to merge 4 commits into
base: feature/cus-3571-fix-model-DashboardInfo-DashboardContainsDashboard
Choose a base branch
from

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Jan 23, 2025

PowerBI Report objects (mapped as DataHub Dashboards) can contain PowerBI Dashboard objects (also DataHub Dashboards).

Important

Depends on PR #12433

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
...ion/src/datahub/ingestion/source/powerbi/config.py 98.45% <100.00%> (+<0.01%) ⬆️
...on/src/datahub/ingestion/source/powerbi/powerbi.py 94.64% <100.00%> (+0.28%) ⬆️
...on/source/powerbi/rest_api_wrapper/data_classes.py 92.99% <100.00%> (+0.03%) ⬆️
...n/source/powerbi/rest_api_wrapper/data_resolver.py 83.60% <ø> (+<0.01%) ⬆️
...ion/source/powerbi/rest_api_wrapper/powerbi_api.py 90.72% <100.00%> (+0.12%) ⬆️

... and 40 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00adc98...97d91d9. Read the comment docs.

@sgomezvillamor sgomezvillamor changed the base branch from master to feature/cus-3571-fix-model-DashboardInfo-DashboardContainsDashboard January 27, 2025 06:39
…insDashboard' into feature/cus-3571/feat-powerbi-report-to-dashboard-lineage
@sgomezvillamor
Copy link
Contributor Author

Tested locally with the generated golden file

datahub ingest mcps /Users/sergio/workspace/github/datahub-project/datahub/metadata-ingestion/tests/integration/powerbi/golden_test_container.json
Screenshot 2025-01-27 at 12 17 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant