Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(cli): Add session management capabilities #12458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Jan 24, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs labels Jan 24, 2025
@pedro93 pedro93 force-pushed the ps-session-manager branch from 1a61ed4 to a762140 Compare January 24, 2025 14:28
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

❌ 31 Tests Failed:

Tests completed Failed Passed Skipped
1909 31 1878 51
View the top 3 failed tests by shortest run time
::tests.integration.kafka.test_kafka
Stack Traces | 0s run time
.../integration/kafka/test_kafka.py:14: in <module>
    from tests.test_helpers.click_helpers import run_datahub_cmd
tests/test_helpers/click_helpers.py:6: in <module>
    from datahub.entrypoints import datahub
src/datahub/entrypoints.py:26: in <module>
    from datahub.cli.session_cli import session
.../datahub/cli/session_cli.py:20: in <module>
    def parse_value(value: str, expected_type: Optional[Type] = None) -> tuple[Any, Optional[str]]:
E   TypeError: 'type' object is not subscriptable
::tests.unit.serde.test_serde
Stack Traces | 0s run time
.../unit/serde/test_serde.py:21: in <module>
    from tests.test_helpers.click_helpers import run_datahub_cmd
tests/test_helpers/click_helpers.py:6: in <module>
    from datahub.entrypoints import datahub
src/datahub/entrypoints.py:26: in <module>
    from datahub.cli.session_cli import session
.../datahub/cli/session_cli.py:20: in <module>
    def parse_value(value: str, expected_type: Optional[Type] = None) -> tuple[Any, Optional[str]]:
E   TypeError: 'type' object is not subscriptable
::tests.unit.test_datahub_emitter
Stack Traces | 0s run time
ImportError while importing test module '.../tests/unit/test_datahub_emitter.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
venv/lib/python3.8.../site-packages/_pytest/python.py:493: in importtestmodule
    mod = import_path(
venv/lib/python3.8.../site-packages/_pytest/pathlib.py:587: in import_path
    importlib.import_module(module_name)
.../hostedtoolcache/Python/3.8.18.../x64/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1014: in _gcd_import
    ???
<frozen importlib._bootstrap>:991: in _find_and_load
    ???
<frozen importlib._bootstrap>:975: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:671: in _load_unlocked
    ???
venv/lib/python3.8.../_pytest/assertion/rewrite.py:184: in exec_module
    exec(co, module.__dict__)
tests/unit/test_datahub_emitter.py:17: in <module>
    from prefect_datahub.datahub_emitter import DatahubEmitter
src/prefect_datahub/datahub_emitter.py:19: in <module>
    from datahub.api.entities.dataprocess.dataprocess_instance import (
../...../entities/dataprocess/dataprocess_instance.py:8: in <module>
    from datahub.emitter.mcp_builder import DatahubKey
../...../datahub/emitter/mcp_builder.py:17: in <module>
    from datahub.ingestion.api.workunit import MetadataWorkUnit
../...../ingestion/api/workunit.py:7: in <module>
    from datahub.ingestion.api.common import WorkUnit
../...../ingestion/api/common.py:5: in <module>
    from datahub.configuration.common import ConfigurationError
../...../datahub/configuration/__init__.py:1: in <module>
    from datahub.configuration.common import (
../...../datahub/configuration/common.py:18: in <module>
    from pydantic.fields import ModelField
E   ImportError: cannot import name 'ModelField' from 'pydantic.fields' (.../venv/lib/python3.8.../site-packages/pydantic/fields.py)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant