fix(ingest/snowflake): Create all structured propery templates before assignation #12469
+135
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
datahub-cyborg
bot
added
the
needs-review
lint fix
asikowitz
requested changes
Jan 28, 2025
| @@ -249,6 +249,11 @@ class SnowflakeV2Config( | |||
| description="If enabled along with `extract_tags`, extracts snowflake's key-value tags as DataHub structured properties instead of DataHub tags.", | |||
| ) | |||
|
|
|||
| structured_properties_template_cache_invalidation_interval: int = Field( | |||
There was a problem hiding this comment.
Maybe hide this one from docs, feels more like an implementation detail
| for tag in self.data_dictionary.get_all_tags(): | ||
| if not self.config.tag_pattern.allowed(tag.tag_identifier()): | ||
| continue | ||
| # Do we need to filter based on database and schema or is it enough if we filter based on tag pattern? |
There was a problem hiding this comment.
I would say no, because you can apply tags from other databases / schemas
Comment on lines
293
to
302
| tags = [] | ||
| for tag in cur: | ||
| snowflake_tag = SnowflakeTag( | ||
| database=tag["TAG_DATABASE"], | ||
| schema=tag["TAG_SCHEMA"], | ||
| name=tag["TAG_NAME"], | ||
| value="", | ||
| ) | ||
| tags.append(snowflake_tag) | ||
| return tags |
There was a problem hiding this comment.
Could be a list comprehension a bit more succinctly
Comment on lines
93
to
94
| for workunit in self.gen_tag_as_structured_property_workunits(tag): | ||
| yield workunit |
There was a problem hiding this comment.
Suggested change
| for workunit in self.gen_tag_as_structured_property_workunits(tag): | |
| yield workunit | |
| yield from self.gen_tag_as_structured_property_workunits(tag) |
| @@ -219,6 +219,7 @@ def test_snowflake_tags_as_structured_properties( | |||
| include_column_lineage=False, | |||
| include_usage_stats=False, | |||
| include_operational_stats=False, | |||
| structured_properties_template_cache_invalidation_interval=1, | |||
There was a problem hiding this comment.
For test I'd prob put this at 0 unless it's needed just to avoid unnecessary sleeps
| @@ -59,6 +78,46 @@ def _get_tags_on_object_without_propagation( | |||
| raise ValueError(f"Unknown domain {domain}") | |||
| return tags | |||
|
|
|||
| def create_structured_property_templates(self) -> Iterable[MetadataWorkUnit]: | |||
| for tag in self.data_dictionary.get_all_tags(): | |||
| if not self.config.tag_pattern.allowed(tag.tag_identifier()): | |||
There was a problem hiding this comment.
Actually, I think structured_property_pattern makes more sense here, right? Our tag_pattern expects a key value pair, not just a key
datahub-cyborg
bot
added
pending-submitter-response
datahub-cyborg
bot
added
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist