-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingestion/teradata): teradata profiling fix for pooling #12507
fix(ingestion/teradata): teradata profiling fix for pooling #12507
Conversation
Teradata sqlalchemy connector does not support max_overflow. replaced with poolclass=QueuePool.
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (44.44%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
metadata-ingestion/src/datahub/ingestion/source/sql/teradata.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/sql/teradata.py
Outdated
Show resolved
Hide resolved
updated pooling comments, removed unwanted changes
metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py
Outdated
Show resolved
Hide resolved
moved comments and added new comments
metadata-ingestion/src/datahub/ingestion/source/sql/teradata.py
Outdated
Show resolved
Hide resolved
Updated comments. Adjusted to only change poolclass.
Checklist
Teradata sqlalchemy connector does not support max_overflow. replaced with poolclass=QueuePool.