Skip to content

feat(ingestion): update the layout of secrets tab #13627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

purnimagarg1
Copy link
Collaborator

@purnimagarg1 purnimagarg1 commented May 26, 2025

Copy link

alwaysmeticulous bot commented May 26, 2025

✅ Meticulous spotted visual differences in 215 of 1354 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 9804942. This comment will update as new commits are pushed.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 26, 2025
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 43.24324% with 294 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-web-react/src/app/ingestV2/secret/SecretsList.tsx 37.82% 97 Missing ⚠️
...ub-web-react/src/app/ingest/secret/SecretsList.tsx 51.04% 70 Missing ⚠️
...b-web-react/src/app/ingest/ManageIngestionPage.tsx 31.31% 68 Missing ⚠️
...eact/src/app/ingest/source/IngestionSourceList.tsx 50.42% 59 Missing ⚠️

📢 Thoughts on this report? Let us know!

@chriscollins3456 chriscollins3456 force-pushed the CH-336-backend-sort-ingestion-table branch from a33c2a0 to 4a39c26 Compare May 29, 2025 16:33
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks solid however i have one comment and a question i sent to you via DM

{record.name}
</TextContainer>
),
sorter: (a: TableDataType, b: TableDataType) => a.name.localeCompare(b.name),
},
{
title: 'Description',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably make the description column larger than the name column. probably like 75% can be description give or take.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels May 29, 2025
@chriscollins3456
Copy link
Collaborator

we'll also need to rebase this PR

@purnimagarg1 purnimagarg1 force-pushed the CH-336-backend-sort-ingestion-table branch from ffc9af2 to 18a32ab Compare May 30, 2025 14:39
@purnimagarg1 purnimagarg1 force-pushed the CH-365-update-secrets-tab branch from 8b69ba0 to a9cd919 Compare May 30, 2025 15:17
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels May 30, 2025
Copy link

codecov bot commented May 30, 2025

Bundle Report

Changes will increase total bundle size by 2.67kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 19.65MB 2.67kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 2.67kB 16.02MB 0.02%

Files in assets/index-*.js:

  • ./src/app/ingest/secret/SecretsList.tsx → Total Size: 8.71kB

  • ./src/app/ingest/source/IngestionSourceList.tsx → Total Size: 14.18kB

  • ./src/app/ingestV2/secret/SecretsList.tsx → Total Size: 8.78kB

  • ./src/app/ingestV2/source/IngestionSourceTableColumns.tsx → Total Size: 7.44kB

  • ./src/app/ingest/ManageIngestionPage.tsx → Total Size: 5.44kB

Base automatically changed from CH-336-backend-sort-ingestion-table to master May 30, 2025 19:51
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid to me

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels May 30, 2025
@chriscollins3456 chriscollins3456 merged commit d2f9db2 into master May 30, 2025
31 of 33 checks passed
@chriscollins3456 chriscollins3456 deleted the CH-365-update-secrets-tab branch May 30, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants