-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(ingestion): update the layout of secrets tab #13627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Meticulous spotted visual differences in 215 of 1354 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~8 hours of user flows against your PR. Last updated for commit 9804942. This comment will update as new commits are pushed. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
a33c2a0
to
4a39c26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks solid however i have one comment and a question i sent to you via DM
{record.name} | ||
</TextContainer> | ||
), | ||
sorter: (a: TableDataType, b: TableDataType) => a.name.localeCompare(b.name), | ||
}, | ||
{ | ||
title: 'Description', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can probably make the description column larger than the name column. probably like 75% can be description give or take.
we'll also need to rebase this PR |
ffc9af2
to
18a32ab
Compare
8b69ba0
to
a9cd919
Compare
Bundle ReportChanges will increase total bundle size by 2.67kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
a9cd919
to
9804942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks solid to me
Linear ticket:
https://linear.app/acryl-data/issue/CH-365/move-saas-secrets-tab-code-to-oss
Screenshot: