Skip to content

feat(ui) Add framework for template/module state and editing templates/modules to UI #14029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1952,6 +1952,15 @@ private void configureCorpUserResolvers(final RuntimeWiring.Builder builder) {
new LoadableTypeResolver<>(
corpUserType,
(env) -> ((CorpUserInfo) env.getSource()).getManager().getUrn())));
builder.type(
"CorpUserHomePageSettings",
typeWiring ->
typeWiring.dataFetcher(
"pageTemplate",
new LoadableTypeResolver<>(
dataHubPageTemplateType,
(env) ->
((CorpUserHomePageSettings) env.getSource()).getPageTemplate().getUrn())));
builder.type(
"CorpUserEditableProperties",
typeWiring ->
Expand Down
28 changes: 17 additions & 11 deletions datahub-web-react/src/app/homeV3/HomePageContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,30 @@ import React from 'react';
import { useGlobalSettings } from '@app/context/GlobalSettingsContext';
import { useUserContext } from '@app/context/useUserContext';
import { Announcements } from '@app/homeV3/announcements/Announcements';
import { PageTemplateProvider } from '@app/homeV3/context/PageTemplateContext';
import { CenteredContainer, ContentContainer, ContentDiv } from '@app/homeV3/styledComponents';
import Template from '@app/homeV3/template/Template';

const HomePageContent = () => {
const { settings } = useGlobalSettings();
const { user } = useUserContext();
const { settings, loaded: globalSettingsLoaded } = useGlobalSettings();
const { user, loaded: userLoaded } = useUserContext();

const template = user?.settings?.homePage?.pageTemplate || settings.globalHomePageSettings?.defaultTemplate;
const personalTemplate = user?.settings?.homePage?.pageTemplate || null;
const globalTemplate = settings.globalHomePageSettings?.defaultTemplate || null;

if (!userLoaded || !globalSettingsLoaded) return null;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll probably want to add some loading state here later


return (
<ContentContainer>
<CenteredContainer>
<ContentDiv>
<Announcements />
<Template template={template} />
</ContentDiv>
</CenteredContainer>
</ContentContainer>
<PageTemplateProvider personalTemplate={personalTemplate} globalTemplate={globalTemplate}>
<ContentContainer>
<CenteredContainer>
<ContentDiv>
<Announcements />
<Template />
</ContentDiv>
</CenteredContainer>
</ContentContainer>
</PageTemplateProvider>
);
};

Expand Down
86 changes: 86 additions & 0 deletions datahub-web-react/src/app/homeV3/context/PageTemplateContext.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
import React, { ReactNode, createContext, useContext, useMemo } from 'react';

import { useModuleOperations } from '@app/homeV3/context/hooks/useModuleOperations';
import { useTemplateOperations } from '@app/homeV3/context/hooks/useTemplateOperations';
import { useTemplateState } from '@app/homeV3/context/hooks/useTemplateState';
import { PageTemplateContextState } from '@app/homeV3/context/types';

import { PageTemplateFragment } from '@graphql/template.generated';

const PageTemplateContext = createContext<PageTemplateContextState | undefined>(undefined);

export const PageTemplateProvider = ({
personalTemplate: initialPersonalTemplate,
globalTemplate: initialGlobalTemplate,
children,
}: {
personalTemplate: PageTemplateFragment | null | undefined;
globalTemplate: PageTemplateFragment | null | undefined;
children: ReactNode;
}) => {
// Template state management
const {
personalTemplate,
globalTemplate,
template,
isEditingGlobalTemplate,
setIsEditingGlobalTemplate,
setPersonalTemplate,
setGlobalTemplate,
setTemplate,
} = useTemplateState(initialPersonalTemplate, initialGlobalTemplate);

// Template operations
const { updateTemplateWithModule, upsertTemplate } = useTemplateOperations();

// Module operations
const { addModule, createModule } = useModuleOperations(
isEditingGlobalTemplate,
personalTemplate,
globalTemplate,
setPersonalTemplate,
setGlobalTemplate,
updateTemplateWithModule,
upsertTemplate,
);

const value = useMemo(
() => ({
personalTemplate,
globalTemplate,
template,
isEditingGlobalTemplate,
setIsEditingGlobalTemplate,
setPersonalTemplate,
setGlobalTemplate,
setTemplate,
addModule,
createModule,
}),
[
personalTemplate,
globalTemplate,
template,
isEditingGlobalTemplate,
setIsEditingGlobalTemplate,
setPersonalTemplate,
setGlobalTemplate,
setTemplate,
addModule,
createModule,
],
);

return <PageTemplateContext.Provider value={value}>{children}</PageTemplateContext.Provider>;
};

export function usePageTemplateContext() {
const context = useContext(PageTemplateContext);
if (!context) {
throw new Error('usePageTemplateContext must be used within a PageTemplateProvider');
}
return context;
}

// Re-export types for convenience
export type { CreateModuleInput, AddModuleInput } from './types';
Loading
Loading