-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(tableau): add support for Google BigQuery connection type in pla… #14080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ 4 Tests Failed:
View the full list of 3 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also going to match connection_types like:
google
glebigqu
etc.
Should be
elif connection_type in ("googlebigquery",):
or
elif connection_type == "googlebigquery":
(And yes the other two above it are similarly broken.)
…and Google BigQuery
added googlebigquery -> bigquery mapping for sql parsing with tableau custom queries.