[WIP] Add a generic and extensible DataBlock component in Vue #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminCharmes
force-pushed
the
bc/extensible-datablock
branch
from
b03f5e0 to
a354154
Compare
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/extensible-datablock
|
| Run status |
|
| Run duration | 06m 50s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
477
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
=======================================
Coverage 70.28% 70.28%
=======================================
Files 63 63
Lines 4133 4133
=======================================
Hits 2905 2905
Misses 1228 1228 🚀 New features to boost your workflow:
|
BenjaminCharmes
force-pushed
the
bc/extensible-datablock
branch
from
487d199 to
36c5f9c
Compare
ml-evs
reviewed
Mar 18, 2025
There was a problem hiding this comment.
Let's try a slightly different approach and work down the block list and try to remove any specialist vue code for that block, e.g., starting at mass spec, try to use it only the BokehBlock for this (removing the mass spec vue code), and then go to the next block and see how much we need to extend the base block. This could also start the migration to block events rather than hardcoded JS.
Add new blockTypes
BenjaminCharmes
force-pushed
the
bc/extensible-datablock
branch
from
627b86d to
30fe5e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1016