Do not update 'files' reference when saving item #1055
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
=======================================
Coverage 71.35% 71.35%
=======================================
Files 63 63
Lines 4151 4151
=======================================
Hits 2962 2962
Misses 1189 1189
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/fix-files
|
| Run status |
|
| Run duration | 07m 42s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
498
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
force-pushed
the
ml-evs/fix-files
branch
2 times, most recently
from
9218c19 to
7f7f8bb
Compare
|
Actually, converting this to a draft to add proper tests and a more general solution at a later date. |
ml-evs
force-pushed
the
ml-evs/fix-files
branch
from
7f7f8bb to
a90f53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally depended on an item having
filessaved in the db, where actually it should only be a field constructed for the API response. This crept through as callingsave-itemfrom the app included this field, and as it fits the pydantic model, it was being saved in the database.We still need a better way of distinguishing such fields between the database and API, by adding special validators to the base entry types and annotating them as such in our models, but this just patches this problem for now.