-
Notifications
You must be signed in to change notification settings - Fork 19
Added synthesis information to starting materials and made component collapsible #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…g to fit with previous style
…ge and trigger an unsaved state
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
+ Coverage 71.35% 71.45% +0.09%
==========================================
Files 63 63
Lines 4151 4162 +11
==========================================
+ Hits 2962 2974 +12
+ Misses 1189 1188 -1
🚀 New features to boost your workflow:
|
datalab
|
Project |
datalab
|
Branch Review |
bes/syninfo-sm
|
Run status |
|
Run duration | 08m 33s |
Commit |
|
Committer | Ben Smith |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
501
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine the test failures are related to the "hidden by default" for this component, see e.g.:
https://cloud.cypress.io/projects/4kqx5i/runs/3060/test-results/69349704-c474-4b9f-a10f-36a43a97b5ef/replay?att=1&ts=1744117996161.6&utm_campaign=view+Test+Replay&utm_medium=failed&utm_source=github which shows that it is failing to find the search box when first loading a page (should be as easy as editing the test to find the heading, clicking it to uncollapse before looking for the search).
It might be worth figuring out how to get the cypress tests running locally on your end (should be as simple as yarn run cypress run --e2e
... but often isn't). Otherwise, the cypress cloud can be very helpful in debugging too (lets you replay the tests in the browser even if they run in the CI).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @be-smith, just a few final tweaks
… into bes/syninfo-sm
Quick note in case I forget in the next 16 minutes -- we should add the starting material info to the add item modal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks @be-smith!
Changed synthesis information to be added to starting materials as well as samples.
If the synthesis info is empty it will start collapsed upon loading the page - otherwise it will start expanded.