Skip to content

Added synthesis information to starting materials and made component collapsible #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 30, 2025

Conversation

be-smith
Copy link
Contributor

@be-smith be-smith commented Apr 8, 2025

Changed synthesis information to be added to starting materials as well as samples.

If the synthesis info is empty it will start collapsed upon loading the page - otherwise it will start expanded.

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.45%. Comparing base (bb599e4) to head (b030369).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   71.35%   71.45%   +0.09%     
==========================================
  Files          63       63              
  Lines        4151     4162      +11     
==========================================
+ Hits         2962     2974      +12     
+ Misses       1189     1188       -1     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/models/samples.py 100.00% <100.00%> (+3.33%) ⬆️
...datalab/src/pydatalab/models/starting_materials.py 100.00% <100.00%> (ø)
pydatalab/src/pydatalab/models/traits.py 98.61% <100.00%> (+1.11%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Apr 8, 2025

datalab    Run #3236

Run Properties:  status check passed Passed #3236  •  git commit b1941a1137 ℹ️: Merge b030369c5fca8b501c4bf3e0e6275c586c2e6a00 into bb599e488bb6574e0adc83b86152...
Project datalab
Branch Review bes/syninfo-sm
Run status status check passed Passed #3236
Run duration 08m 33s
Commit git commit b1941a1137 ℹ️: Merge b030369c5fca8b501c4bf3e0e6275c586c2e6a00 into bb599e488bb6574e0adc83b86152...
Committer Ben Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 501
View all changes introduced in this branch ↗︎

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine the test failures are related to the "hidden by default" for this component, see e.g.:

https://cloud.cypress.io/projects/4kqx5i/runs/3060/test-results/69349704-c474-4b9f-a10f-36a43a97b5ef/replay?att=1&ts=1744117996161.6&utm_campaign=view+Test+Replay&utm_medium=failed&utm_source=github which shows that it is failing to find the search box when first loading a page (should be as easy as editing the test to find the heading, clicking it to uncollapse before looking for the search).

2025-04-08-143437_519x410_scrot

It might be worth figuring out how to get the cypress tests running locally on your end (should be as simple as yarn run cypress run --e2e... but often isn't). Otherwise, the cypress cloud can be very helpful in debugging too (lets you replay the tests in the browser even if they run in the CI).

@ml-evs ml-evs changed the title Bes/syninfo sm Added synthesis information to starting materials and make component collapsible Apr 8, 2025
@ml-evs ml-evs changed the title Added synthesis information to starting materials and make component collapsible Add synthesis information to starting materials and make component collapsible Apr 8, 2025
@ml-evs ml-evs changed the title Add synthesis information to starting materials and make component collapsible Added synthesis information to starting materials and made component collapsible Apr 8, 2025
@be-smith be-smith marked this pull request as ready for review April 22, 2025 17:46
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @be-smith, just a few final tweaks

@ml-evs ml-evs added webapp For issues/PRs pertaining to the web interface schema For issues/PRs pertaining to data models and schemas labels Apr 23, 2025
@ml-evs ml-evs added this to the v0.5.x milestone Apr 25, 2025
@ml-evs
Copy link
Member

ml-evs commented Apr 30, 2025

Quick note in case I forget in the next 16 minutes -- we should add the starting material info to the add item modal

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks @be-smith!

@ml-evs ml-evs merged commit c8b31c3 into main Apr 30, 2025
17 checks passed
@ml-evs ml-evs deleted the bes/syninfo-sm branch April 30, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema For issues/PRs pertaining to data models and schemas webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants