-
Notifications
You must be signed in to change notification settings - Fork 19
Multiselect filtering for "no values" in nblocks column #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
Coverage 70.28% 70.28%
=======================================
Files 63 63
Lines 4129 4129
=======================================
Hits 2902 2902
Misses 1227 1227 🚀 New features to boost your workflow:
|
datalab
|
Project |
datalab
|
Branch Review |
bc/filter-noblock
|
Run status |
|
Run duration | 07m 31s |
Commit |
|
Committer | Ben Charmes |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
477
|
View all changes introduced in this branch ↗︎ |
I haven't tried on this branch, but I was also noticing that "match any" seems to always match samples with 0 blocks. Is that easy to fix? |
This is doing something a bit strange on my local instance, filtering for "match all" -> "no blocks" still leaves some entries that have blocks. Perhaps relatedly, on main and this PR, if I try to simply sort in ascending order by the blocks column, it starts with the entries with 1 block rather than 0. |
Thank for the review @jdbocarsly & @ml-evs !
I'm going to take a closer look at all this! |
Realised what is causing this behaviour: when you copy a sample that has blocks, the block is copied identically and then the API summary doesn't include it even though |
Closes #1104